Fix another case where scrollToMakeVisible was off.

Fix another case where scrollToMakeVisible was off.

AXObject::elementRect returns coordinates relative to the
frame, so we don't need to do any offsetting when scrolling
the main frame's scroll area.

However, when we're scrolling something other than a frame,
like a scrollable div, we need to put the element we're
trying to make visible into the local coordinate frame of
the scrollable div before we know how much to scroll it.

BUG=459937, 457973
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194818

[dmazzoni, 2015-04-30 22:43:17]

dmazzoni@chromium.org changed reviewers:
+ je_julie.kim@samsung.com

[je_julie(Not used), 2015-05-01 16:14:38]

lgtm!

https://codereview.chromium.org/1118753004/diff/1/Source/modules/accessibilit...
File Source/modules/accessibility/AXObject.cpp (right):

https://codereview.chromium.org/1118753004/diff/1/Source/modules/accessibilit...
Source/modules/accessibility/AXObject.cpp:1138: if
(!scrollParent->isAXScrollView()) {
Don't we need null checking for scrollParent?
Because other member functions are checking it.

[dmazzoni, 2015-05-01 16:51:51]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-05-01 16:51:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
je_julie.kim@samsung.com
Link to the patchset: https://codereview.chromium.org/1118753004/#ps20001
(title: "null-check scrollParent")

[commit-bot: I haz the power, 2015-05-01 16:52:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1118753004/20001

[dmazzoni, 2015-05-01 16:52:23]

https://codereview.chromium.org/1118753004/diff/1/Source/modules/accessibilit...
File Source/modules/accessibility/AXObject.cpp (right):

https://codereview.chromium.org/1118753004/diff/1/Source/modules/accessibilit...
Source/modules/accessibility/AXObject.cpp:1138: if
(!scrollParent->isAXScrollView()) {
On 2015/05/01 16:14:38, je_julie wrote:
> Don't we need null checking for scrollParent?
> Because other member functions are checking it.

It's supposed to not reach this far if scrollParent is null. I added an explicit
check to be sure, thanks.

[commit-bot: I haz the power, 2015-05-01 18:16:18]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194818