Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: chrome/browser/ui/omnibox/omnibox_view.h

Issue 111873004: [OriginChip] Show and select the URL on alt-d/ctrl-l. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: All files this time. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_view.h
diff --git a/chrome/browser/ui/omnibox/omnibox_view.h b/chrome/browser/ui/omnibox/omnibox_view.h
index 1899590c4f8c6e49fd38349a7724ea2b2335fc71..2565ad5cb4271520a1331461c6148d4a77150a22 100644
--- a/chrome/browser/ui/omnibox/omnibox_view.h
+++ b/chrome/browser/ui/omnibox/omnibox_view.h
@@ -135,6 +135,10 @@ class OmniboxView {
// avoid selecting the "phantom newline" at the end of the edit.
virtual void SelectAll(bool reversed) = 0;
+ // Sets focus, disables search term replacement, reverts the omnibox, and
msw 2013/12/12 00:59:21 Make sure the definition order matches this revise
Justin Donnelly 2013/12/12 17:11:57 Done.
+ // selects all.
+ void ShowURL();
+
// Re-enables search term replacement on the ToolbarModel, and reverts the
// edit and popup back to their unedited state (permanent text showing, popup
// closed, no user input in progress).
@@ -256,9 +260,6 @@ class OmniboxView {
// Internally invoked whenever the text changes in some way.
virtual void TextChanged();
- // Disables search term replacement, reverts the omnibox, and selects all.
- void ShowURL();
-
// Return the number of characters in the current buffer. The name
// |GetTextLength| can't be used as the Windows override of this class
// inherits from a class that defines a method with that name.
« no previous file with comments | « no previous file | chrome/browser/ui/omnibox/omnibox_view.cc » ('j') | chrome/browser/ui/views/location_bar/location_bar_view.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698