[OriginChip] Show and select the URL on alt-d/ctrl-l.

[OriginChip] Show and select the URL on alt-d/ctrl-l.

To support this, make OmniboxView::ShowURL public and make it grab focus so that it works in contexts other than the Omnibox's right-click menu.

BUG=315944
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240444

[Greg Billock, 2013-12-11 19:37:35]

https://codereview.chromium.org/111873004/diff/1/chrome/browser/ui/omnibox/om...
File chrome/browser/ui/omnibox/omnibox_view.cc (right):

https://codereview.chromium.org/111873004/diff/1/chrome/browser/ui/omnibox/om...
chrome/browser/ui/omnibox/omnibox_view.cc:164: void OmniboxView::ShowURL() {
Is making the method public done in another change? I'd add it here.

[Justin Donnelly, 2013-12-11 19:48:35]

Oops, git fail.  All files included now.

[Greg Billock, 2013-12-11 21:31:14]

https://codereview.chromium.org/111873004/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/location_bar/location_bar_view.h (right):

https://codereview.chromium.org/111873004/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/location_bar/location_bar_view.h:246: OmniboxViewViews*
omnibox_view() { return omnibox_view_; }
Should this be OmniboxView and promote ShowURL to the interface?

[msw, 2013-12-12 00:59:21]

Hmm, this behavior is a little odd. Just to make sure, UX wants the URL suddenly
shown on Ctrl+L, Alt+D, and F6, (since it may have been hidden or replaced with
a search term), but left as-is on tab-to-focus or click-to-focus?

https://codereview.chromium.org/111873004/diff/20001/chrome/browser/ui/omnibo...
File chrome/browser/ui/omnibox/omnibox_view.h (right):

https://codereview.chromium.org/111873004/diff/20001/chrome/browser/ui/omnibo...
chrome/browser/ui/omnibox/omnibox_view.h:138: // Sets focus, disables search
term replacement, reverts the omnibox, and
Make sure the definition order matches this revised declaration order, and don't
conflict with https://codereview.chromium.org/110893004/

[Justin Donnelly, 2013-12-12 17:11:49]

On 2013/12/12 00:59:21, msw wrote:
> Hmm, this behavior is a little odd. Just to make sure, UX wants the URL
suddenly
> shown on Ctrl+L, Alt+D, and F6, (since it may have been hidden or replaced
with
> a search term), but left as-is on tab-to-focus or click-to-focus?

Yes, this is the required behavior, as specified in the PRD
(https://docs.google.com/a/google.com/document/d/19RQEQZKHCgJVgvSdb-K1PYNXYfXE...).
 It is a bit odd but the motivation is to provide a convenient keyboard shortcut
to surface the URL.  If the only way to make the URL appear was a button click
there'd be no easy keyboard-based way to edit or copy the URL.

[Justin Donnelly, 2013-12-12 17:11:57]

https://codereview.chromium.org/111873004/diff/20001/chrome/browser/ui/omnibo...
File chrome/browser/ui/omnibox/omnibox_view.h (right):

https://codereview.chromium.org/111873004/diff/20001/chrome/browser/ui/omnibo...
chrome/browser/ui/omnibox/omnibox_view.h:138: // Sets focus, disables search
term replacement, reverts the omnibox, and
On 2013/12/12 00:59:21, msw wrote:
> Make sure the definition order matches this revised declaration order, and
don't
> conflict with https://codereview.chromium.org/110893004/

Done.

https://codereview.chromium.org/111873004/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/location_bar/location_bar_view.h (right):

https://codereview.chromium.org/111873004/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/location_bar/location_bar_view.h:246: OmniboxViewViews*
omnibox_view() { return omnibox_view_; }
On 2013/12/11 21:31:14, Greg Billock wrote:
> Should this be OmniboxView and promote ShowURL to the interface?

ShowUrl is already in OmniboxView.  I made this OmniboxViewViews because the
accessor is used to call methods in two of its superclasses (ShowURL in
OmniboxViews and IsFocusable in views::Textfield).

[msw, 2013-12-12 18:01:18]

LGTM; thanks for the doc link.

[commit-bot: I haz the power, 2013-12-12 18:16:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jdonnelly@chromium.org/111873004/40001

[commit-bot: I haz the power, 2013-12-12 22:19:00]

Change committed as 240444