lib/html/scripts/systemhtml.py - Issue 11187063: Generate contains() method for list mixin only if not already defined.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/html/scripts/systemhtml.py

Issue 11187063: Generate contains() method for list mixin only if not already defined. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/html/scripts/systemhtml.py

diff --git a/lib/html/scripts/systemhtml.py b/lib/html/scripts/systemhtml.py

index ec157338dbdc8476489cfc730e5eaba93705824a..697cbab8f6e4063dd49c8bb568e8a1750839888c 100644

--- a/lib/html/scripts/systemhtml.py

+++ b/lib/html/scripts/systemhtml.py

@@ -698,7 +698,10 @@ class Dart2JSBackend(object):

# TODO(sra): Use separate mixins for typed array implementations of List<T>.

if self._interface.id != 'NodeList':

template_file = 'immutable_list_mixin.darttemplate'

- template = self._template_loader.Load(template_file)

+ has_contains = any(op.id == 'contains' for op in self._interface.operations)

+ template = self._template_loader.Load(

+ template_file,

+ {'DEFINE_CONTAINS': not has_contains})

self._members_emitter.Emit(template, E=self._DartType(element_type))

def AddAttribute(self, attribute, html_name, read_only):

« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | lib/html/scripts/systemnative.py » ('j') | no next file with comments »