Handle resubmission of HTTP Posts.

content/browser/web_contents/navigation_controller_impl.cc

Index: content/browser/web_contents/navigation_controller_impl.cc
diff --git a/content/browser/web_contents/navigation_controller_impl.cc b/content/browser/web_contents/navigation_controller_impl.cc
index 150c5dc77e312a1cc836475b4d7ea88bbed615a2..4292e8bb778d97fa206540a840ad6289d5538030 100644
--- a/content/browser/web_contents/navigation_controller_impl.cc
+++ b/content/browser/web_contents/navigation_controller_impl.cc
@@ -310,13 +310,17 @@ void NavigationControllerImpl::ReloadInternal(bool check_for_repost,
     // The user is asking to reload a page with POST data. Prompt to make sure
     // they really want to do this. If they do, the dialog will call us back
     // with check_for_repost = false.
-    content::NotificationService::current()->Notify(
-        content::NOTIFICATION_REPOST_WARNING_SHOWN,
-        content::Source<NavigationController>(this),
-        content::NotificationService::NoDetails());
-
+    if (content::NotificationService::current()) {
+      // TODO(sgurun) What is the proper way to handle this? create in
+      // contentviewcore?

[joth, 2012/10/17 20:35:53]

this is a damn good question:
- NotificationService::Create() is only called in a couple random places on
(desktop) chrome, and we'll (eventually) not go through any of those in webview.
I think we probably should explicitly call it somewhere.
- but the way NotificationService::current() is used through-out this file, it
looks like it's mandatory to have one installed, so I'm surprised other tests
etc aren't already hitting this problem?
- just to check, you are calling through to this method on main (UI) thread?
NotificationService is thread-local, so this would be finding null if called on
wrong thread. seems related to the question about which Looper the EventHandler
is constructed on.

[sgurun-gerrit only, 2012/10/17 22:08:18]

I am sure this is not created at present. Even with the looper change I don't
see it (but regardless, I am creating AwContentsClient in main thread, which the
event handler loop is also running).

On 2012/10/17 20:35:53, joth wrote:

+      content::NotificationService::current()->Notify(
+          content::NOTIFICATION_REPOST_WARNING_SHOWN,
+          content::Source<NavigationController>(this),
+          content::NotificationService::NoDetails());
+    }
     pending_reload_ = reload_type;
     web_contents_->Activate();
+    // TODO(sgurun) change the name to onFormResubmission

[joth, 2012/10/17 20:35:53]

nits:
// TODO(sgurun): change the name to OnFormResubmission

also assuming the above NotificationService change isn't needed, probably
easiest to leave this out of this CL as changing files here pulls in extra
layers of reviews.

[sgurun-gerrit only, 2012/10/17 22:08:18]

Yep let's leave it out. 

On 2012/10/17 20:35:53, joth wrote:

     web_contents_->GetDelegate()->ShowRepostFormWarningDialog(web_contents_);
   } else {
     DiscardNonCommittedEntriesInternal();