Handle resubmission of HTTP Posts.

android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
index 87fda075bdab43f3508b3bcacd5d44998926d45b..f536bb6cbccd8c79ec03df670ed0102aeb6e2114 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
@@ -6,6 +6,9 @@ package org.chromium.android_webview;
 
 import android.graphics.Rect;
 import android.graphics.RectF;
+import android.os.Handler;
+import android.os.Looper;
+import android.os.Message;
 import android.util.Log;
 import android.view.KeyEvent;
 import android.webkit.ConsoleMessage;
@@ -37,6 +40,34 @@ public abstract class AwContentsClient extends ContentViewClient {
     //--------------------------------------------------------------------------------------------
 
     class WebContentsDelegateAdapter extends AwWebContentsDelegate {
+
+        // The message ids.
+        public final static int CONTINUE_PENDING_RELOAD = 1;
+        public final static int CANCEL_PENDING_RELOAD = 2;
+
+        // Handler associated with this adapter.
+        private final Handler mHandler = new Handler(Looper.getMainLooper()) {
+
+            @Override
+            public void handleMessage(Message msg) {
+                ContentViewCore contentViewCore = null;
+                switch (msg.what) {
+                case CONTINUE_PENDING_RELOAD:
+                    contentViewCore = (ContentViewCore)msg.obj;
+                    if (contentViewCore != null) {

[joth, 2012/10/23 00:05:31]

the == null cases here should be impossible, as we do a null-check on the native
side before calling showRepostFormWarningDialog(), and it can't go out of scope
between there and here as the Message is holding  a hard ref to the object.
So I'd skio the local var and just say:
(ContentViewCore)msg.obj).continuePendingReload();

[sgurun-gerrit only, 2012/10/23 00:28:11]

Done.

+                        contentViewCore.continuePendingReload();
+                    }
+                    break;
+                case CANCEL_PENDING_RELOAD:
+                    contentViewCore = (ContentViewCore)msg.obj;
+                    if (contentViewCore != null) {
+                        contentViewCore.cancelPendingReload();
+                    }
+                    break;
+                }
+            }
+        };
+
         @Override
         public void onLoadProgressChanged(int progress) {
             AwContentsClient.this.onProgressChanged(progress);
@@ -99,6 +130,13 @@ public abstract class AwContentsClient extends ContentViewClient {
         public void onUrlStarredChanged(boolean starred) {
             // TODO: implement
         }
+
+        @Override
+        public void showRepostFormWarningDialog(Object contentViewCore) {

[joth, 2012/10/23 00:05:31]

nit: replace "Object" with "ContentViewCore" here. While we pass it over the
message as an object, it will at least help catch and native-side misuse at
earliest point we can.

[sgurun-gerrit only, 2012/10/23 00:28:11]

Done.

+            Message dontResend = mHandler.obtainMessage(CANCEL_PENDING_RELOAD, contentViewCore);
+            Message resend = mHandler.obtainMessage(CONTINUE_PENDING_RELOAD, contentViewCore);
+            AwContentsClient.this.onFormResubmission(dontResend, resend);
+        }
     }
 
     class AwWebContentsObserver extends WebContentsObserverAndroid {
@@ -153,6 +191,8 @@ public abstract class AwContentsClient extends ContentViewClient {
     public abstract void onReceivedHttpAuthRequest(AwHttpAuthHandler handler,
             String host, String realm);
 
+    public abstract void onFormResubmission(Message dontResend, Message resend);
+
     protected abstract void handleJsAlert(String url, String message, JsResultReceiver receiver);
 
     protected abstract void handleJsBeforeUnload(String url, String message,