Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 11187006: Update example comments based on feedback form Mark (Closed)

Created:
8 years, 2 months ago by Sam Clegg
Modified:
8 years, 2 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Update example comments based on feedback form Mark BUG= Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1453

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.cc View 3 chunks +5 lines, -5 lines 4 comments Download

Messages

Total messages: 2 (0 generated)
Sam Clegg
8 years, 2 months ago (2012-10-16 19:05:00 UTC) #1
binji
8 years, 2 months ago (2012-10-16 19:53:55 UTC) #2
lgtm

http://codereview.chromium.org/11187006/diff/1/visual_studio/NativeClientVSAd...
File
visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.cc
(right):

http://codereview.chromium.org/11187006/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.cc:33:
// NaClProjectInstance:Init, launching hello_nacl_plus in its own window. Since
::Init

http://codereview.chromium.org/11187006/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.cc:43:
// What changed: NaClProjectInstance:Init calls initInstanceInBrowserWindow
capitalize initInstanceInBrowserWindow

http://codereview.chromium.org/11187006/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.cc:43:
// What changed: NaClProjectInstance:Init calls initInstanceInBrowserWindow
::Init

http://codereview.chromium.org/11187006/diff/1/visual_studio/NativeClientVSAd...
visual_studio/NativeClientVSAddIn/InstallerResources/examples/hello_nacl_cpp/hello_nacl_cpp/hello_nacl_cpp.cc:44:
// rather than initInstanceInPCWindow. The initInstanceInBrowserWindow uses
capitalize initInstanceInPCWindow

Powered by Google App Engine
This is Rietveld 408576698