Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1118693002: MIPS: Add min/max suffixed variants. (Closed)

Created:
5 years, 7 months ago by dusmil.imgtec
Modified:
5 years, 7 months ago
Reviewers:
djordje.pesic, balazs.kilvady, paul.l..., akos.palfi.imgtec
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Add min/max suffixed variants. TEST= BUG= Committed: https://crrev.com/76ddd58cff4bc5bcb93578ffd050e4a38a1edcd1 Cr-Commit-Position: refs/heads/master@{#28181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -8 lines) Patch
M src/mips/assembler-mips.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-disasm-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dusmil.imgtec
5 years, 7 months ago (2015-04-30 12:30:14 UTC) #2
balazs.kilvady
Should not we add the same alias names for sel*.[s|d] ops?
5 years, 7 months ago (2015-04-30 12:40:32 UTC) #3
dusmil.imgtec
Yes, we could in the other CL. We have not used them yet. This CL ...
5 years, 7 months ago (2015-04-30 12:58:17 UTC) #4
balazs.kilvady
lgtm
5 years, 7 months ago (2015-04-30 16:17:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118693002/1
5 years, 7 months ago (2015-04-30 16:20:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 16:43:06 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 16:43:28 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76ddd58cff4bc5bcb93578ffd050e4a38a1edcd1
Cr-Commit-Position: refs/heads/master@{#28181}

Powered by Google App Engine
This is Rietveld 408576698