Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 1118673002: Implement ReadableStream as a V8 extra (Closed)

Created:
5 years, 7 months ago by domenic
Modified:
5 years, 4 months ago
Reviewers:
CC:
blink-reviews, yhirano
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Implement ReadableStream as a V8 extra Passes all tests at https://streams.spec.whatwg.org/tests/ that don't depend on other classes (e.g. WritableStream). Originally a port of the reference implementation at https://github.com/whatwg/streams/blob/master/reference-implementation/lib/readable-stream.js but modified for efficiency and information-hiding. Does not implement pipeTo or pipeThrough since there are no WritableStreams or TransformStreams yet. Depends on the following modification to Chromium's build/common.gypi: @@ -1479,6 +1479,11 @@ # Compile d8 for the host toolset. 'v8_toolset_for_d8': 'host', + # Add the streams V8 extension to the snapshot + 'v8_extra_library_files': [ + '../third_party/WebKit/Source/core/streams/ByteLengthQueuingStrategy.js', + '../third_party/WebKit/Source/core/streams/CountQueuingStrategy.js', + '../third_party/WebKit/Source/core/streams/ReadableStream.js', + ], + # Use brlapi from brltty for braille display support. 'use_brlapi%': 0, BUG=

Patch Set 1 #

Patch Set 2 : Add queuing strategies #

Patch Set 3 : Clarify imports; manually bind Promise static methods #

Patch Set 4 : #

Patch Set 5 : Complete set of C++ classes, I think. #

Patch Set 6 : It mostly compiles now #

Patch Set 7 : Update with small fixes/big TODOs after review with jochen. #

Patch Set 8 : Use extras exports object. FOrgot some files. #

Patch Set 9 : Working a bit on the extras exports stuff #

Patch Set 10 : #

Patch Set 11 : Actually works! #

Patch Set 12 : Cleanups; make controller a member instead of arg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1287 lines, -4 lines) Patch
M Source/bindings/core/v8/ScriptState.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/ScriptState.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +9 lines, -0 lines 0 comments Download
M Source/bindings/scripts/idl_types.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/scripts/v8_types.py View 1 2 3 4 5 6 7 8 9 10 3 chunks +3 lines, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 3 4 5 6 7 8 9 10 2 chunks +16 lines, -0 lines 0 comments Download
A Source/core/streams/ByteLengthQueuingStrategy.js View 1 2 3 4 5 6 7 8 9 1 chunk +18 lines, -0 lines 0 comments Download
A Source/core/streams/CountQueuingStrategy.js View 1 2 3 4 5 6 7 8 9 1 chunk +18 lines, -0 lines 0 comments Download
A Source/core/streams/ReadableStream.js View 1 2 3 4 5 6 7 8 9 10 1 chunk +741 lines, -0 lines 0 comments Download
A Source/core/streams/ScriptQueuingStrategy.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +25 lines, -0 lines 0 comments Download
A Source/core/streams/ScriptQueuingStrategy.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +23 lines, -0 lines 0 comments Download
A Source/core/streams/ScriptQueuingStrategy.idl View 1 2 3 4 5 6 7 8 9 1 chunk +14 lines, -0 lines 0 comments Download
A Source/core/streams/ScriptReadableStream.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +83 lines, -0 lines 0 comments Download
A Source/core/streams/ScriptReadableStream.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +31 lines, -0 lines 0 comments Download
A Source/core/streams/ScriptReadableStreamController.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +31 lines, -0 lines 0 comments Download
A Source/core/streams/ScriptReadableStreamController.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +95 lines, -0 lines 0 comments Download
A Source/core/streams/ScriptUnderlyingSource.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +40 lines, -0 lines 0 comments Download
A Source/core/streams/ScriptUnderlyingSource.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +37 lines, -0 lines 0 comments Download
A Source/core/streams/ScriptUnderlyingSource.idl View 1 2 3 4 5 6 7 8 9 10 1 chunk +15 lines, -0 lines 0 comments Download
A Source/core/streams/StreamTest.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +21 lines, -0 lines 0 comments Download
A Source/core/streams/StreamTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +61 lines, -0 lines 0 comments Download
A + Source/core/streams/StreamTest.idl View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698