Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: Source/bindings/core/v8/ToV8.h

Issue 1118653002: Componentization: add toV8(void*,...) to check function overload mismatch. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ToV8.h
diff --git a/Source/bindings/core/v8/ToV8.h b/Source/bindings/core/v8/ToV8.h
index c5f193f827d0dd85f43ebd069bba439c2f79c9e6..7b6c0773335d821f78009a055515b389005b3961 100644
--- a/Source/bindings/core/v8/ToV8.h
+++ b/Source/bindings/core/v8/ToV8.h
@@ -237,6 +237,11 @@ inline v8::Local<v8::Value> toV8(const Vector<std::pair<String, T>>& value, v8::
return object;
}
+// Only declare toV8(void*,...) for checking function overload mismatch.
+// This toV8(void*,...) should be never used. So we will find mismatch
+// because of "unresolved external symbol".
Yuki 2015/05/01 04:26:42 Could you add a following comment? Without toV8(v
tasak 2015/05/01 05:16:49 Done.
+v8::Handle<v8::Value> toV8(void* value, v8::Handle<v8::Object> creationContext, v8::Isolate*);
+
} // namespace blink
#endif // ToV8_h
« no previous file with comments | « no previous file | Source/modules/background_sync/SyncCallbacks.h » ('j') | Source/modules/background_sync/SyncCallbacks.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698