LayoutTests/media/track/track-language-preference.html - Issue 1118613002: Hook up Android closed captions 'enabled' setting to Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/media/track/track-language-preference.html

Issue 1118613002: Hook up Android closed captions 'enabled' setting to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed lgtm comment and rebased Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/media/track/track-language-preference.html

diff --git a/LayoutTests/media/track/track-language-preference.html b/LayoutTests/media/track/track-language-preference.html

index 428f27e4160cd31335d2dd08939b00cb8cb74c29..2782b8eb56def1dac4448fef75b5181336ddcbb0 100644

--- a/LayoutTests/media/track/track-language-preference.html

+++ b/LayoutTests/media/track/track-language-preference.html

@@ -76,6 +76,7 @@

consoleWrite("<i>**Set user preferred languages<" + "/i>");

run("internals.setUserPreferredLanguages(['jp', 'es-ES', 'en', 'fr'])");

+ window.internals.settings.setTextTrackKindUserPreference('captions');

}

function createTrackElement(language, src)

@@ -103,7 +104,7 @@

{

findMediaElement();

- setPreferences("Subtitles", true);

+ setPreferences();

runNextTest();

}

« no previous file with comments | « LayoutTests/media/track/track-kind-user-preference-expected.txt ('k') | Source/core/frame/Settings.h » ('j') | no next file with comments »