Source/core/page/Page.cpp - Issue 1118613002: Hook up Android closed captions 'enabled' setting to Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/Page.cpp

Issue 1118613002: Hook up Android closed captions 'enabled' setting to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed comment from fs Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/track/AutomaticTrackSelection.cpp ('K') | « Source/core/html/track/TextTrackKindUserPreference.h ('k') | Source/core/testing/InternalSettings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/Page.cpp

diff --git a/Source/core/page/Page.cpp b/Source/core/page/Page.cpp

index bcbb175c612174016ed1ac4a1395b937f2d8b9db..d65564c79073db69d7cf1b55d2e7610188712cce 100644

--- a/Source/core/page/Page.cpp

+++ b/Source/core/page/Page.cpp

@@ -495,6 +495,13 @@ void Page::settingsChanged(SettingsDelegate::ChangeType changeType)

doc->styleResolver()->viewportStyleResolver()->collectViewportRules();

}

break;

+ case SettingsDelegate::TextTrackKindUserPreferenceChange:

+ for (Frame* frame = mainFrame(); frame; frame = frame->tree().traverseNext()) {

+ if (frame->isLocalFrame()) {

+ toLocalFrame(frame)->document()->textTrackKindUserPreferenceChanged();

+ }

+ break;

}