Source/core/frame/Settings.in - Issue 1118613002: Hook up Android closed captions 'enabled' setting to Blink

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/frame/Settings.in

Issue 1118613002: Hook up Android closed captions 'enabled' setting to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated automatic track selection logic Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Defines properties which are available on the Settings object.	1 # Defines properties which are available on the Settings object.

2 #	2 #

3 # Please think carefully before adding a new Setting. Some questions to	3 # Please think carefully before adding a new Setting. Some questions to

4 # consider are:	4 # consider are:

5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things	5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things

6 # which we support either values of at runtime. Features are set at renderer	6 # which we support either values of at runtime. Features are set at renderer

7 # process startup and are never changed. Features also tend to be set to a	7 # process startup and are never changed. Features also tend to be set to a

8 # value based on the platform or the stability of the code in question, where	8 # value based on the platform or the stability of the code in question, where

9 # as settings both codepaths need to be stable.	9 # as settings both codepaths need to be stable.

10 # - How will you ensure test coverage of all relevant values of your setting?	10 # - How will you ensure test coverage of all relevant values of your setting?

(...skipping 306 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
317 disableReadingFromCanvas initial=false	317 disableReadingFromCanvas initial=false

318 strictMixedContentChecking initial=false	318 strictMixedContentChecking initial=false

319 strictPowerfulFeatureRestrictions initial=false	319 strictPowerfulFeatureRestrictions initial=false

320 logDnsPrefetchAndPreconnect initial=false	320 logDnsPrefetchAndPreconnect initial=false

321 logPreload initial=false	321 logPreload initial=false

322	322

323 # If true, the UA styles will include viewportAndroid.css. It is used for	323 # If true, the UA styles will include viewportAndroid.css. It is used for

324 # Android, and dynamically set by the inspector for mobile emulation.	324 # Android, and dynamically set by the inspector for mobile emulation.

325 useMobileViewportStyle initial=false, invalidate=ViewportRule	325 useMobileViewportStyle initial=false, invalidate=ViewportRule

326	326

	327 # AutomaticTrackSelection is performed based on user preference for track kind s pecified

	328 # by this setting.

	329 textTrackKindUserPreference type=TextTrackKindUserPreference, initial=TextTrackK indUserPreference::Default, invalidate=TextTrackKindUserPreference

	330

327 # User style overrides for captions and subtitles	331 # User style overrides for captions and subtitles

328 textTrackBackgroundColor type=String	332 textTrackBackgroundColor type=String

329 textTrackFontFamily type=String	333 textTrackFontFamily type=String

330 textTrackFontStyle type=String	334 textTrackFontStyle type=String

331 textTrackFontVariant type=String	335 textTrackFontVariant type=String

332 textTrackTextColor type=String	336 textTrackTextColor type=String

333 textTrackTextShadow type=String	337 textTrackTextShadow type=String

334 textTrackTextSize type=String	338 textTrackTextSize type=String

OLD	NEW

« no previous file with comments | « Source/core/frame/Settings.h ('k') | Source/core/frame/SettingsDelegate.h » ('j') | Source/core/html/track/AutomaticTrackSelection.cpp » ('J')