Source/core/frame/Settings.in - Issue 1118613002: Hook up Android closed captions 'enabled' setting to Blink

Side by Side Diff: Source/core/frame/Settings.in

Issue 1118613002: Hook up Android closed captions 'enabled' setting to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have the flag influence automatic track selection Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Defines properties which are available on the Settings object.	1 # Defines properties which are available on the Settings object.

2 #	2 #

3 # Please think carefully before adding a new Setting. Some questions to	3 # Please think carefully before adding a new Setting. Some questions to

4 # consider are:	4 # consider are:

5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things	5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things

6 # which we support either values of at runtime. Features are set at renderer	6 # which we support either values of at runtime. Features are set at renderer

7 # process startup and are never changed. Features also tend to be set to a	7 # process startup and are never changed. Features also tend to be set to a

8 # value based on the platform or the stability of the code in question, where	8 # value based on the platform or the stability of the code in question, where

9 # as settings both codepaths need to be stable.	9 # as settings both codepaths need to be stable.

10 # - How will you ensure test coverage of all relevant values of your setting?	10 # - How will you ensure test coverage of all relevant values of your setting?

(...skipping 303 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
314	314

315 disableReadingFromCanvas initial=false	315 disableReadingFromCanvas initial=false

316 strictMixedContentChecking initial=false	316 strictMixedContentChecking initial=false

317 strictPowerfulFeatureRestrictions initial=false	317 strictPowerfulFeatureRestrictions initial=false

318 logDnsPrefetchAndPreconnect initial=false	318 logDnsPrefetchAndPreconnect initial=false

319	319

320 # If true, the UA styles will include viewportAndroid.css. It is used for	320 # If true, the UA styles will include viewportAndroid.css. It is used for

321 # Android, and dynamically set by the inspector for mobile emulation.	321 # Android, and dynamically set by the inspector for mobile emulation.

322 useMobileViewportStyle initial=false, invalidate=ViewportRule	322 useMobileViewportStyle initial=false, invalidate=ViewportRule

323	323

	324 # User setting for text tracks visibility

	325 textTracksEnabled initial=false, invalidate=TextTracksVisibility
	philipj_slow 2015/05/06 09:54:27 This is about as nitpicky as it gets, but I think This is about as nitpicky as it gets, but I think it should be TextTrackVisibility as "text track visibility" cover both the single and plural cases. srivats 2015/06/09 00:45:51 Done. Show quoted text On 2015/05/06 09:54:27, philipj wrote: > This is about as nitpicky as it gets, but I think it should be > TextTrackVisibility as "text track visibility" cover both the single and plural > cases. Done.
	326

324 # User style overrides for captions and subtitles	327 # User style overrides for captions and subtitles

325 textTrackBackgroundColor type=String	328 textTrackBackgroundColor type=String

326 textTrackFontFamily type=String	329 textTrackFontFamily type=String

327 textTrackFontStyle type=String	330 textTrackFontStyle type=String

328 textTrackFontVariant type=String	331 textTrackFontVariant type=String

329 textTrackTextColor type=String	332 textTrackTextColor type=String

330 textTrackTextShadow type=String	333 textTrackTextShadow type=String

331 textTrackTextSize type=String	334 textTrackTextSize type=String

OLD	NEW

« Source/core/dom/Document.cpp ('K') | « Source/core/dom/Document.cpp ('k') | Source/core/frame/SettingsDelegate.h » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')