ui/DEPS - Issue 11186039: Move CC switches to cc/switches.h.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/DEPS

Issue 11186039: Move CC switches to cc/switches.h. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Update login_utils Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+cc",
	tfarina 2012/10/18 17:31:33 hum? these is going to introduce a circular depend hum? these is going to introduce a circular dependency! cc/ depends on ui/, now ui/ depends on cc/ Please, can you avoid this? I think you meant to add this to ui/compositor/DEPS instead. tfarina 2012/10/18 17:32:10 sorry, typed too fast. s/these/this Show quoted text On 2012/10/18 17:31:33, tfarina wrote: > hum? these is going to introduce a circular dependency! > sorry, typed too fast. s/these/this sky 2012/10/18 17:38:27 Good point. That needs to be straightened out. Show quoted text On 2012/10/18 17:32:10, tfarina wrote: > On 2012/10/18 17:31:33, tfarina wrote: > > hum? these is going to introduce a circular dependency! > > > sorry, typed too fast. s/these/this > > Good point. That needs to be straightened out.
2 "+chromeos/dbus",	3 "+chromeos/dbus",

3 "+grit/app_locale_settings.h",	4 "+grit/app_locale_settings.h",

4 "+grit/native_theme_resources.h",	5 "+grit/native_theme_resources.h",

5 "+grit/ui_resources.h",	6 "+grit/ui_resources.h",

6 "+grit/ui_strings.h",	7 "+grit/ui_strings.h",

7 "+jni",	8 "+jni",

8 "+net",	9 "+net",

9 "+skia",	10 "+skia",

10 "+third_party/mozilla",	11 "+third_party/mozilla",

11 "+third_party/skia",	12 "+third_party/skia",

12 ]	13 ]

OLD	NEW