Issue 11186036: Implement size and position support for launchWebAuthFlow.

Issue 11186036: Implement size and position support for launchWebAuthFlow. (Closed)

Created:
8 years, 2 months ago by Mihai Parparita -not on Chrome

Modified:
8 years, 2 months ago

Reviewers:
Munjal (Google)

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement size and position support for launchWebAuthFlow. Also fix a bug where we would still try to close WebContents in a WebAuthFlow where the contents had already been destroyed. Also remove some indentity API test files, the test that used them was removed with r148017. BUG=132143 R=munjal@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162639

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix unit tests #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -43 lines)			Patch
M	chrome/browser/extensions/api/identity/identity_api.cc	View		2 chunks	+17 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/identity/identity_apitest.cc	View		3 chunks	+63 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/identity/web_auth_flow.h	View		3 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/identity/web_auth_flow.cc	View		3 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/api/identity/web_auth_flow_unittest.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/experimental_identity.idl	View		1 chunk	+12 lines, -0 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/identity/manifest.json	View		1 chunk	+0 lines, -12 lines	0 comments	Download
D	chrome/test/data/extensions/api_test/identity/test.js	View		1 chunk	+0 lines, -23 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Munjal (Google)

LGTM https://codereview.chromium.org/11186036/diff/1/chrome/common/extensions/api/experimental_identity.idl File chrome/common/extensions/api/experimental_identity.idl (right): https://codereview.chromium.org/11186036/diff/1/chrome/common/extensions/api/experimental_identity.idl#newcode30 chrome/common/extensions/api/experimental_identity.idl:30: long? top; Nit: do we use individual fields ...

8 years, 2 months ago (2012-10-17 23:09:44 UTC) #2

Mihai Parparita -not on Chrome

https://codereview.chromium.org/11186036/diff/1/chrome/common/extensions/api/experimental_identity.idl File chrome/common/extensions/api/experimental_identity.idl (right): https://codereview.chromium.org/11186036/diff/1/chrome/common/extensions/api/experimental_identity.idl#newcode30 chrome/common/extensions/api/experimental_identity.idl:30: long? top; On 2012/10/17 23:09:44, munjal wrote: > Nit: ...

8 years, 2 months ago (2012-10-17 23:13:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/11186036/1

8 years, 2 months ago (2012-10-17 23:14:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/11186036/1009

8 years, 2 months ago (2012-10-18 01:22:29 UTC) #5

Change committed as 162639

Expand Messages | Collapse Messages