[Telemetry] Change HTMLOutputFormatter to be based on chart JSON

[Telemetry] Change HTMLOutputFormatter to be based on chart JSON

This CL modifies HTMLOutputFormatter so that it is no longer based on Buildbot output.

BUG=477056
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_nexus5_perf_bisect

Committed: https://crrev.com/d522cf5a1615d2b1fdf5e1e9b3f385f75d687c1a
Cr-Commit-Position: refs/heads/master@{#327830}

Committed: https://crrev.com/31e7f2c1fd8aa2a5369e794338daec9ad523d921
Cr-Commit-Position: refs/heads/master@{#328019}

[eakuefner, 2015-04-30 00:35:54]

eakuefner@chromium.org changed reviewers:
+ nednguyen@google.com

[nednguyen, 2015-04-30 19:18:08]

https://codereview.chromium.org/1118593002/diff/40001/tools/telemetry/telemet...
File tools/telemetry/telemetry/results/chart_json_output_formatter.py (right):

https://codereview.chromium.org/1118593002/diff/40001/tools/telemetry/telemet...
tools/telemetry/telemetry/results/chart_json_output_formatter.py:69: def
_ResultsAsChartDict(self, page_test_results):
Just make this a static public method.

[eakuefner, 2015-04-30 21:25:52]

https://codereview.chromium.org/1118593002/diff/40001/tools/telemetry/telemet...
File tools/telemetry/telemetry/results/chart_json_output_formatter.py (right):

https://codereview.chromium.org/1118593002/diff/40001/tools/telemetry/telemet...
tools/telemetry/telemetry/results/chart_json_output_formatter.py:69: def
_ResultsAsChartDict(self, page_test_results):
On 2015/04/30 19:18:08, nednguyen wrote:
> Just make this a static public method.

Done.

[nednguyen, 2015-04-30 21:40:31]

lgtm
Great work!

[eakuefner, 2015-04-30 21:57:19]

The CQ bit was checked by eakuefner@chromium.org

[commit-bot: I haz the power, 2015-04-30 21:59:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1118593002/60001

[eakuefner, 2015-04-30 22:25:57]

The CQ bit was unchecked by eakuefner@chromium.org

[eakuefner, 2015-04-30 22:27:20]

The CQ bit was checked by eakuefner@chromium.org

[commit-bot: I haz the power, 2015-04-30 22:28:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1118593002/60001

[commit-bot: I haz the power, 2015-04-30 23:24:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-30 23:25:42]

Patchset 4 (id:??) landed as
https://crrev.com/d522cf5a1615d2b1fdf5e1e9b3f385f75d687c1a
Cr-Commit-Position: refs/heads/master@{#327830}

[alancutter (OOO until 2018), 2015-05-01 07:08:07]

On 2015/04/30 at 23:25:42, commit-bot wrote:
> Patchset 4 (id:??) landed as
https://crrev.com/d522cf5a1615d2b1fdf5e1e9b3f385f75d687c1a
> Cr-Commit-Position: refs/heads/master@{#327830}

This change appears to have broken the perf trybots.

The command:
$ tools/perf/run_benchmark -v smoothness.top_25_smooth --browser=system
--page-filter=cnn
fails with:
Traceback (most recent call last):
  <module> at tools/perf/run_benchmark:20
    sys.exit(benchmark_runner.main(environment))
  main at tools/telemetry/telemetry/benchmark_runner.py:383
    return command().Run(options)
  Run at tools/telemetry/telemetry/benchmark_runner.py:193
    return min(255, self._benchmark().Run(args))
  Run at tools/telemetry/telemetry/benchmark.py:213
    results.PrintSummary()
  PrintSummary at tools/telemetry/telemetry/results/page_test_results.py:208
    output_formatter.Format(self)
  Format at tools/telemetry/telemetry/results/html_output_formatter.py:140
    self._TranslateChartJson(chart_json_dict)
  _TranslateChartJson at
tools/telemetry/telemetry/results/html_output_formatter.py:113
    value = value_module.Value.FromDict(value_dict, dummy_dict)
  FromDict at tools/telemetry/telemetry/value/__init__.py:242
    return Value.ListOfValuesFromListOfDicts([value_dict], page_dict)[0]
  ListOfValuesFromListOfDicts at tools/telemetry/telemetry/value/__init__.py:268
    'Subclass doesn\'t override FromDict'
AssertionError: Subclass doesn't override FromDict

Telemetry changes should have
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_nexus6_perf_bisect in their
description to avoid tree breakages.
Hopefully one day we'll have rules to tell the CQ to run specific trybots when
particular directories are changed.

[eakuefner, 2015-05-01 07:18:15]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1119983003/ by eakuefner@chromium.org.

The reason for reverting is: Broke perf trybots.

[eakuefner, 2015-05-01 07:20:33]

On 2015/05/01 at 07:08:07, alancutter wrote:
> On 2015/04/30 at 23:25:42, commit-bot wrote:
> > Patchset 4 (id:??) landed as
https://crrev.com/d522cf5a1615d2b1fdf5e1e9b3f385f75d687c1a
> > Cr-Commit-Position: refs/heads/master@{#327830}
> 
> This change appears to have broken the perf trybots.
> 
> The command:
> $ tools/perf/run_benchmark -v smoothness.top_25_smooth --browser=system
--page-filter=cnn
> fails with:
> Traceback (most recent call last):
>   <module> at tools/perf/run_benchmark:20
>     sys.exit(benchmark_runner.main(environment))
>   main at tools/telemetry/telemetry/benchmark_runner.py:383
>     return command().Run(options)
>   Run at tools/telemetry/telemetry/benchmark_runner.py:193
>     return min(255, self._benchmark().Run(args))
>   Run at tools/telemetry/telemetry/benchmark.py:213
>     results.PrintSummary()
>   PrintSummary at tools/telemetry/telemetry/results/page_test_results.py:208
>     output_formatter.Format(self)
>   Format at tools/telemetry/telemetry/results/html_output_formatter.py:140
>     self._TranslateChartJson(chart_json_dict)
>   _TranslateChartJson at
tools/telemetry/telemetry/results/html_output_formatter.py:113
>     value = value_module.Value.FromDict(value_dict, dummy_dict)
>   FromDict at tools/telemetry/telemetry/value/__init__.py:242
>     return Value.ListOfValuesFromListOfDicts([value_dict], page_dict)[0]
>   ListOfValuesFromListOfDicts at
tools/telemetry/telemetry/value/__init__.py:268
>     'Subclass doesn\'t override FromDict'
> AssertionError: Subclass doesn't override FromDict
> 
> Telemetry changes should have
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_nexus6_perf_bisect in their
description to avoid tree breakages.
> Hopefully one day we'll have rules to tell the CQ to run specific trybots when
particular directories are changed.

Thanks for reporting this, Alan. We have plans to move Telemetry to its own
waterfall, and I think that should help to preemptively address these kinds of
breakages as well.

[eakuefner, 2015-05-01 22:23:53]

The CQ bit was checked by eakuefner@chromium.org

[eakuefner, 2015-05-01 22:23:54]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1118593002/#ps80001
(title: "Explicitly ignore TraceValues in chart JSON translator")

[commit-bot: I haz the power, 2015-05-01 22:24:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1118593002/80001

[commit-bot: I haz the power, 2015-05-01 23:50:19]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-01 23:51:18]

Patchset 5 (id:??) landed as
https://crrev.com/31e7f2c1fd8aa2a5369e794338daec9ad523d921
Cr-Commit-Position: refs/heads/master@{#328019}