Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 1118553002: FontConfig character/lang match requires weak family. (Closed)

Created:
5 years, 7 months ago by bungeman-skia
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

FontConfig character/lang match requires weak family. In FontConfig the normal priority order of matches is character, family, language; however family can be marked as weak which changes the order to character, language, family. This is what is desired in matchFamilyStyleCharacter. Committed: https://skia.googlesource.com/skia/+/1d4ec0a1ad4998c32c6a28ff4b85000553ff686d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/ports/SkFontMgr_fontconfig.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
bungeman-chromium
Fixing the test in a previous CL revealed this bug. The issue is that the ...
5 years, 7 months ago (2015-04-29 18:13:59 UTC) #2
reed1
lgtm
5 years, 7 months ago (2015-04-29 18:26:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118553002/1
5 years, 7 months ago (2015-04-29 18:27:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/1d4ec0a1ad4998c32c6a28ff4b85000553ff686d
5 years, 7 months ago (2015-04-29 18:33:06 UTC) #6
bungeman-chromium
On 2015/04/29 18:33:06, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
5 years, 7 months ago (2015-04-29 19:21:06 UTC) #7
bungeman-chromium
5 years, 7 months ago (2015-04-29 19:30:09 UTC) #8
Message was sent while issue was closed.
On 2015/04/29 19:21:06, bungeman2 wrote:
> On 2015/04/29 18:33:06, I haz the power (commit-bot) wrote:
> > Committed patchset #1 (id:1) as
> >
https://skia.googlesource.com/skia/+/1d4ec0a1ad4998c32c6a28ff4b85000553ff686d
> 
> Note that this fixed 'Droid Sans Fallback' and 'Droid Sans Japanese' since
they
> actually exhibited this issue. On the other hand, there appear to be a number
of
> fonts which seem to just be set up with the wrong language settings. I'll have
> to take a look into that separately.

This also fixed ChromeOS completely, since it appears they have a more
controlled and explicit configuration for FontConfig.

Powered by Google App Engine
This is Rietveld 408576698