Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1118533003: Make CPU profiler do not hog 100% of CPU. (Closed)

Created:
5 years, 7 months ago by alph
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make CPU profiler do not hog 100% of CPU. Tick event processor should not stay in a tight loop when there's nothing to do. It can go sleep until next sample event. LOG=N BUG=v8:3967 Committed: https://crrev.com/6964a9e0685fa186d9d9b7907be17505e839db1a Cr-Commit-Position: refs/heads/master@{#28211}

Patch Set 1 #

Patch Set 2 : Do not use Sleep on Windows #

Total comments: 4

Patch Set 3 : rebaseline #

Patch Set 4 : rebaseline #

Patch Set 5 : uploading patch #3 #

Patch Set 6 : still uploading #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -22 lines) Patch
M src/base/platform/platform.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/base/platform/platform-posix.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/base/platform/platform-win32.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/cpu-profiler.cc View 1 1 chunk +21 lines, -5 lines 0 comments Download
M src/optimizing-compile-dispatcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/sampler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-log.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 28 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118533003/1
5 years, 7 months ago (2015-04-29 15:23:47 UTC) #2
alph
Folks, please take a look. Thanks.
5 years, 7 months ago (2015-04-29 15:28:01 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-29 15:57:37 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118533003/20001
5 years, 7 months ago (2015-04-29 18:57:33 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-29 19:35:46 UTC) #10
Benedikt Meurer
https://codereview.chromium.org/1118533003/diff/20001/src/cpu-profiler.cc File src/cpu-profiler.cc (right): https://codereview.chromium.org/1118533003/diff/20001/src/cpu-profiler.cc#newcode140 src/cpu-profiler.cc:140: #if V8_OS_WIN I don't really like this special casing ...
5 years, 7 months ago (2015-04-30 05:06:01 UTC) #11
yurys
https://codereview.chromium.org/1118533003/diff/20001/src/cpu-profiler.cc File src/cpu-profiler.cc (right): https://codereview.chromium.org/1118533003/diff/20001/src/cpu-profiler.cc#newcode140 src/cpu-profiler.cc:140: #if V8_OS_WIN On 2015/04/30 05:06:01, Benedikt Meurer wrote: > ...
5 years, 7 months ago (2015-04-30 08:10:02 UTC) #12
alph
https://codereview.chromium.org/1118533003/diff/20001/src/cpu-profiler.cc File src/cpu-profiler.cc (right): https://codereview.chromium.org/1118533003/diff/20001/src/cpu-profiler.cc#newcode140 src/cpu-profiler.cc:140: #if V8_OS_WIN On 2015/04/30 05:06:01, Benedikt Meurer wrote: > ...
5 years, 7 months ago (2015-04-30 10:13:34 UTC) #13
noordhuis
Just a suggestion but sem_post() is async signal-safe; it can wake up the event processor ...
5 years, 7 months ago (2015-04-30 10:15:07 UTC) #14
alph
On 2015/04/30 10:15:07, noordhuis wrote: > Just a suggestion but sem_post() is async signal-safe; it ...
5 years, 7 months ago (2015-04-30 10:27:53 UTC) #15
noordhuis
On 2015/04/30 10:27:53, alph wrote: > On 2015/04/30 10:15:07, noordhuis wrote: > > Just a ...
5 years, 7 months ago (2015-04-30 10:45:07 UTC) #16
yurys
lgtm, looks like there is no better option for Windows. On 2015/04/30 10:13:34, alph wrote: ...
5 years, 7 months ago (2015-04-30 11:53:20 UTC) #17
alph
On 2015/04/30 10:45:07, noordhuis wrote: > On 2015/04/30 10:27:53, alph wrote: > > On 2015/04/30 ...
5 years, 7 months ago (2015-04-30 12:02:08 UTC) #18
Benedikt Meurer
lgtm
5 years, 7 months ago (2015-05-04 04:55:28 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118533003/20001
5 years, 7 months ago (2015-05-04 06:49:35 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/63) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 7 months ago (2015-05-04 06:50:59 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118533003/100001
5 years, 7 months ago (2015-05-04 21:47:25 UTC) #26
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-04 22:53:34 UTC) #27
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 22:53:46 UTC) #28
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/6964a9e0685fa186d9d9b7907be17505e839db1a
Cr-Commit-Position: refs/heads/master@{#28211}

Powered by Google App Engine
This is Rietveld 408576698