rAc: support street-address.

rAc: support street-address.

BUG=330084
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243724

[Evan Stade, 2014-01-07 22:08:45]

ping

[Ilya Sherman, 2014-01-08 00:09:34]

https://codereview.chromium.org/111853012/diff/70002/chrome/browser/ui/autofi...
File chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc (right):

https://codereview.chromium.org/111853012/diff/70002/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc:1192:
shipping_address.form_control_type = "textarea";
Hmm, did you mean these to be modifying shipping_address_textarea?

https://codereview.chromium.org/111853012/diff/70002/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc:1195:
billing_address.form_control_type = "textarea";
Likewise, did you mean these to be modifying billing_address_textarea?

https://codereview.chromium.org/111853012/diff/70002/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc:1221:
form_structure()->field(0)->Type().GetStorableType());
Why do you check this for fields 0 and 1, but not 2 and 3?

[Evan Stade, 2014-01-08 22:16:56]

https://codereview.chromium.org/111853012/diff/70002/chrome/browser/ui/autofi...
File chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc (right):

https://codereview.chromium.org/111853012/diff/70002/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc:1192:
shipping_address.form_control_type = "textarea";
On 2014/01/08 00:09:35, Ilya Sherman (Away Jan11-Feb2) wrote:
> Hmm, did you mean these to be modifying shipping_address_textarea?

ah yes, I did mean to. Good thing the tests didn't pass with this mistake
present!

https://codereview.chromium.org/111853012/diff/70002/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc:1195:
billing_address.form_control_type = "textarea";
On 2014/01/08 00:09:35, Ilya Sherman (Away Jan11-Feb2) wrote:
> Likewise, did you mean these to be modifying billing_address_textarea?

Done.

https://codereview.chromium.org/111853012/diff/70002/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc:1221:
form_structure()->field(0)->Type().GetStorableType());
On 2014/01/08 00:09:35, Ilya Sherman (Away Jan11-Feb2) wrote:
> Why do you check this for fields 0 and 1, but not 2 and 3?

Because that would be redundant, imo. That should only depend on the
autocomplete attribute, which is not different between |*_address| and
|*_address_textarea|. Redundancy doesn't hurt necessarily, but it does make the
test longer, harder to read, more unwieldy to change or refactor, etc., so
generally I prefer to avoid redundancy.

However in this case, I do not feel particularly strongly about it if you want
me to change it.

[Ilya Sherman, 2014-01-08 22:32:03]

LGTM, thanks.

[commit-bot: I haz the power, 2014-01-08 22:38:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/111853012/300001

[commit-bot: I haz the power, 2014-01-08 23:08:04]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-01-08 23:17:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/111853012/300001

[commit-bot: I haz the power, 2014-01-09 01:24:56]

Change committed as 243724