Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 111853011: Fix a warning in libusb. (Closed)

Created:
6 years, 12 months ago by Nico
Modified:
6 years, 11 months ago
Reviewers:
Daniel Erat, Bei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Fix a warning in libusb. A new clang warns about this: ../../third_party/libusb/src/libusb/os/darwin_usb.c:1271:27: error: expression which evaluates to zero treated as a null pointer constant of type 'IOUSBInterfaceInterface550 **' (aka 'struct IOUSBInterfaceStruct550 **') [-Werror,-Wnon-literal-null-conversion] cInterface->interface = IO_OBJECT_NULL; ^~~~~~~~~~~~~~ The warning looks correct to me. I filed upstream ticket 147 for this: http://libusb.org/moderator/confirm/147 (currently awaiting moderation). BUG=323668 TBR=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242548

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M third_party/libusb/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libusb/src/libusb/os/darwin_usb.c View 1 chunk +1 line, -1 line 0 comments Download
A third_party/libusb/upstream-tick147.patch View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
6 years, 12 months ago (2013-12-23 07:35:25 UTC) #1
Daniel Erat
lgtm
6 years, 11 months ago (2013-12-26 16:41:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/111853011/40001
6 years, 11 months ago (2013-12-26 16:42:04 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=42769
6 years, 11 months ago (2013-12-26 17:02:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/111853011/40001
6 years, 11 months ago (2013-12-26 17:05:26 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2013-12-26 19:49:45 UTC) #6
Message was sent while issue was closed.
Change committed as 242548

Powered by Google App Engine
This is Rietveld 408576698