Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 111853008: Add command line flag for optionally loading JS from external files. (Closed)

Created:
7 years ago by jcgregorio
Modified:
7 years ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add command line flag for optionally loading JS from external files. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12692

Patch Set 1 #

Patch Set 2 : retry. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -11 lines) Patch
M experimental/SkV8Example/SkV8Example.cpp View 2 chunks +22 lines, -11 lines 0 comments Download
A experimental/SkV8Example/sample.js View 1 chunk +13 lines, -0 lines 0 comments Download
M gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jcgregorio
7 years ago (2013-12-16 17:54:25 UTC) #1
robertphillips
lgtm
7 years ago (2013-12-16 18:10:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/111853008/20001
7 years ago (2013-12-16 18:12:58 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-16 18:24:53 UTC) #4
Message was sent while issue was closed.
Change committed as 12692

Powered by Google App Engine
This is Rietveld 408576698