Handle additional messages in the NaCl PpapiDispatcher.

Handle additional messages in the NaCl PpapiDispatcher.
This is needed to make the host resolver interface work. The SSH beta now
works with this change.
BUG=116317
TEST=SSH app works
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162550

[piman, 2012-10-17 20:24:41]

http://codereview.chromium.org/11185039/diff/1/ppapi/proxy/plugin_main_nacl.cc
File ppapi/proxy/plugin_main_nacl.cc (right):

http://codereview.chromium.org/11185039/diff/1/ppapi/proxy/plugin_main_nacl.c...
ppapi/proxy/plugin_main_nacl.cc:184: OnPluginDispatcherMessageReceived(msg))
Is there a reason why we whitelist the messages we forward to dispatchers? Why
not forward them all?

[bbudge, 2012-10-17 20:41:05]

Added another handler, and updated the issue.

http://codereview.chromium.org/11185039/diff/1/ppapi/proxy/plugin_main_nacl.cc
File ppapi/proxy/plugin_main_nacl.cc (right):

http://codereview.chromium.org/11185039/diff/1/ppapi/proxy/plugin_main_nacl.c...
ppapi/proxy/plugin_main_nacl.cc:184: OnPluginDispatcherMessageReceived(msg))
On 2012/10/17 20:24:41, piman wrote:
> Is there a reason why we whitelist the messages we forward to dispatchers? Why
> not forward them all?

We exclude code that won't be useful for NaCl apps, such as all Flash proxy
code. This reduces the porting effort and helps make the IRT nexes (NaCl
binaries that contain the plugin side of the proxy) smaller. You reminded me
that we also need the PPB_NetworkMonitor ACK message handled too, so I've added
that. Good question.

[piman, 2012-10-17 20:50:20]

On 2012/10/17 20:41:05, bbudge1 wrote:
> Added another handler, and updated the issue.
> 
> http://codereview.chromium.org/11185039/diff/1/ppapi/proxy/plugin_main_nacl.cc
> File ppapi/proxy/plugin_main_nacl.cc (right):
> 
>
http://codereview.chromium.org/11185039/diff/1/ppapi/proxy/plugin_main_nacl.c...
> ppapi/proxy/plugin_main_nacl.cc:184: OnPluginDispatcherMessageReceived(msg))
> On 2012/10/17 20:24:41, piman wrote:
> > Is there a reason why we whitelist the messages we forward to dispatchers?
Why
> > not forward them all?
> 
> We exclude code that won't be useful for NaCl apps, such as all Flash proxy
> code. This reduces the porting effort and helps make the IRT nexes (NaCl
> binaries that contain the plugin side of the proxy) smaller. You reminded me
> that we also need the PPB_NetworkMonitor ACK message handled too, so I've
added
> that. Good question.

Sure, but what would go wrong if you did forward all the messages? You wouldn't
send an unsupported message anyway. Worst case, there's no handler in the nacl
version, and it'll just be dropped by the PluginDispatcher

[bbudge, 2012-10-17 20:51:04]

Removed whitelist.

http://codereview.chromium.org/11185039/diff/1/ppapi/proxy/plugin_main_nacl.cc
File ppapi/proxy/plugin_main_nacl.cc (right):

http://codereview.chromium.org/11185039/diff/1/ppapi/proxy/plugin_main_nacl.c...
ppapi/proxy/plugin_main_nacl.cc:184: OnPluginDispatcherMessageReceived(msg))
Oh, I see your point now. I'll make this forward all such messages.

[piman, 2012-10-17 20:51:29]

lgtm