Android WebView: create a java module.

Android WebView: create a java module.

The WebView needs a bunch of Java code from the Chromium tree
(contentview and its dependencies) in order to build. Introduce an
Android build system makefile into android_webview which builds a
suitable static java library.

R=benm@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162404

[benm (inactive), 2012-10-17 13:56:44]

lgtm

nice!

[Torne, 2012-10-17 14:03:38]

Forgot to actually include this new makefile from the top-level one. New patch
uploaded.

[boliu, 2012-10-17 14:09:23]

I removed most of the Android.mk files downstream and thought they will be
generated by gyp eventually. So I'm confused why we are adding this now.
Enlighten me?

https://gerrit-int.chromium.org/26983
https://gerrit-int.chromium.org/27057

On Wed, Oct 17, 2012 at 7:03 AM, <torne@chromium.org> wrote:

> Forgot to actually include this new makefile from the top-level one. New
> patch
> uploaded.
>
>
https://codereview.chromium.**org/11185025/<https://codereview.chromium.org/1...
>
> --
>
>
>

[Torne, 2012-10-17 14:11:52]

On 2012/10/17 14:09:23, boliu wrote:
> I removed most of the Android.mk files downstream and thought they will be
> generated by gyp eventually. So I'm confused why we are adding this now.
> Enlighten me?

gyp doesn't handle building the java code, in any configuration. The SDK build
defers to manually written ant buildfiles for this; we are deferring to manually
written Android makefiles for this (well, just one; this one does the whole
lot).

The downstream change you made to have all this code directly compiled by the
glue layer means that in our "real" build config we would have to include source
code from a compeltely different Android project (since the glue lives in the
framework, not in the snapshot of the Chromium sources). The dependencies are
broken that way. It's much safer to build the Chromium java code inside the
Chromium project, and just depend on the built library.

> https://gerrit-int.chromium.org/26983
> https://gerrit-int.chromium.org/27057
> 
> On Wed, Oct 17, 2012 at 7:03 AM, <mailto:torne@chromium.org> wrote:
> 
> > Forgot to actually include this new makefile from the top-level one. New
> > patch
> > uploaded.
> >
> >
>
https://codereview.chromium.**org/11185025/%3Chttps://codereview.chromium.org...>
> >
> > --
> >
> >
> >

[benm (inactive), 2012-10-17 14:24:55]

lgtm

[joth, 2012-10-17 21:43:09]

lgtm

https://codereview.chromium.org/11185025/diff/2002/android_webview/Android.mk
File android_webview/Android.mk (right):

https://codereview.chromium.org/11185025/diff/2002/android_webview/Android.mk...
android_webview/Android.mk:34: $(call all-java-files-under,
../chrome/browser/component/navigation_interception/java/src) \
move these two /chrome/browser/component deps out from under the "TODO - remove"
comment.
could add to the big section on line 20, but that further reduces the utility of
the comment on line 18 "contentview"  :-)