Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: chrome/browser/autofill/autofill_external_delegate.cc

Issue 11185011: Remove TabContents from autofill unittests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove some Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_external_delegate.cc
diff --git a/chrome/browser/autofill/autofill_external_delegate.cc b/chrome/browser/autofill/autofill_external_delegate.cc
index 933241e63ab8d194707b550746b46f1e96d004b8..fc2edb638e0b8efe33e9e23a313392c5ede8b38d 100644
--- a/chrome/browser/autofill/autofill_external_delegate.cc
+++ b/chrome/browser/autofill/autofill_external_delegate.cc
@@ -111,9 +111,8 @@ void AutofillExternalDelegate::OnSuggestionsReturned(
popup_visible_ = true;
ApplyAutofillSuggestions(values, labels, icons, ids);
- AutofillManager::FromWebContents(web_contents_)->
- OnDidShowAutofillSuggestions(
- has_autofill_item && !has_shown_autofill_popup_for_current_edit_);
+ autofill_manager_->OnDidShowAutofillSuggestions(
Avi (use Gerrit) 2012/10/16 22:04:28 This is a bug in your current unit tests. Fixed he
+ has_autofill_item && !has_shown_autofill_popup_for_current_edit_);
has_shown_autofill_popup_for_current_edit_ |= has_autofill_item;
}
}

Powered by Google App Engine
This is Rietveld 408576698