Remove TabContents from autofill unittests.

chrome/browser/autofill/autofill_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_manager.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 188 matching lines @@
       disable_download_manager_requests_(false),
       metric_logger_(new AutofillMetrics),
       has_logged_autofill_enabled_(false),
       has_logged_address_suggestions_count_(false),
       did_show_suggestions_(false),
       user_did_type_(false),
       user_did_autofill_(false),
       user_did_edit_autofilled_field_(false),
       password_generation_enabled_(false),
       external_delegate_(NULL) {
+  // The AutofillManager requires the AutocompleteHistoryManager.
+  AutocompleteHistoryManager::CreateForWebContents(web_contents);

[Avi (use Gerrit), 2012/10/16 22:04:28]

This is a very interesting question. Is the AutocompleteHistoryManager useful
apart from the AutofillManager? Right now, the AutofillManager flat-out requires
the AutocompleteHistoryManager, and heck, the AutocompleteHistoryManager's unit
test requires instantiation of an AutofillManager.

I think I might not have gone far enough; perhaps we should just make the
AutocompleteHistoryManager a member of AutofillManager and be done with it.

[Ilya Sherman, 2012/10/19 00:05:27]

I think that's reasonable.

   // |personal_data_| is NULL when using test-enabled WebContents.
   personal_data_ = PersonalDataManagerFactory::GetForProfile(
       delegate->GetOriginalProfile());
   RegisterWithSyncService();
   registrar_.Init(manager_delegate_->GetPrefs());
   registrar_.Add(prefs::kPasswordGenerationEnabled, this);
 }
 
 AutofillManager::~AutofillManager() {
 }
@@ skipping 90 matching lines @@
                                   false);
   }
 }
 
 void AutofillManager::DidNavigateMainFrame(
     const content::LoadCommittedDetails& details,
     const content::FrameNavigateParams& params) {
   Reset();
 }
 
+void AutofillManager::SetExternalDelegate(AutofillExternalDelegate* delegate) {
+  // TODO(jrg): consider passing delegate into the ctor.  That won't
+  // work if the delegate has a pointer to the AutofillManager, but
+  // future directions may not need such a pointer.
+  external_delegate_ = delegate;
+  AutocompleteHistoryManager::FromWebContents(web_contents())->
+      SetExternalDelegate(delegate);
+}
+
 bool AutofillManager::HasExternalDelegate() {
   return external_delegate_ != NULL;
 }
 
 bool AutofillManager::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(AutofillManager, message)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_FormsSeen, OnFormsSeen)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_FormSubmitted, OnFormSubmitted)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_TextFieldDidChange,
@@ skipping 578 matching lines @@
       has_logged_autofill_enabled_(false),
       has_logged_address_suggestions_count_(false),
       did_show_suggestions_(false),
       user_did_type_(false),
       user_did_autofill_(false),
       user_did_edit_autofilled_field_(false),
       password_generation_enabled_(false),
       external_delegate_(NULL) {
   DCHECK(web_contents);
   DCHECK(manager_delegate_);
+  // The AutofillManager requires the AutocompleteHistoryManager.
+  AutocompleteHistoryManager::CreateForWebContents(web_contents);
   RegisterWithSyncService();
   // Test code doesn't need registrar_.
 }
 
 void AutofillManager::set_metric_logger(const AutofillMetrics* metric_logger) {
   metric_logger_.reset(metric_logger);
 }
 
 bool AutofillManager::GetHost(const std::vector<AutofillProfile*>& profiles,
                               const std::vector<CreditCard*>& credit_cards,
@@ skipping 473 matching lines @@
   *profile_guid = IDToGUID(profile_id);
 }
 
 void AutofillManager::UpdateInitialInteractionTimestamp(
     const TimeTicks& interaction_timestamp) {
   if (initial_interaction_timestamp_.is_null() ||
       interaction_timestamp < initial_interaction_timestamp_) {
     initial_interaction_timestamp_ = interaction_timestamp;
   }
 }