Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1118473005: Apply automated fixits for Chrome clang plugin to sandbox. (Closed)

Created:
5 years, 7 months ago by dcheng
Modified:
5 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5), Nico
CC:
chromium-reviews, rickyz+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply automated fixits for Chrome clang plugin to sandbox. Working on trimming down plugin warnings on the Windows clang build. BUG=467287 TBR=cpu@chromium.org Committed: https://crrev.com/7e7213dae82225490cc15fc25ac3c093708609f1 Cr-Commit-Position: refs/heads/master@{#327558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -86 lines) Patch
M sandbox/win/src/address_sanitizer_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/eat_resolver.h View 1 chunk +13 lines, -13 lines 0 comments Download
M sandbox/win/src/filesystem_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/handle_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/ipc_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/named_pipe_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/process_mitigations_win32k_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/process_thread_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/registry_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/service_resolver.h View 4 chunks +22 lines, -22 lines 0 comments Download
M sandbox/win/src/sidestep_resolver.h View 2 chunks +20 lines, -20 lines 0 comments Download
M sandbox/win/src/sync_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/target_services.h View 1 chunk +8 lines, -8 lines 0 comments Download
M sandbox/win/src/win2k_threadpool.h View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 7 months ago (2015-04-29 18:57:03 UTC) #2
Nico
lgtm
5 years, 7 months ago (2015-04-29 19:03:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118473005/1
5 years, 7 months ago (2015-04-29 19:04:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 21:28:53 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 21:30:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e7213dae82225490cc15fc25ac3c093708609f1
Cr-Commit-Position: refs/heads/master@{#327558}

Powered by Google App Engine
This is Rietveld 408576698