Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1118473002: [mojo] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, Pranay
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in mojo module. MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Committed: https://crrev.com/332a1b2b1d5635199d5ed453f5f9586b2e030b64 Cr-Commit-Position: refs/heads/master@{#328311}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed comment #

Patch Set 3 : Fixing build break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -19 lines) Patch
M mojo/application/content_handler_factory.cc View 4 chunks +11 lines, -7 lines 0 comments Download
M mojo/common/handle_watcher.cc View 1 2 4 chunks +8 lines, -7 lines 0 comments Download
M mojo/runner/child_process.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M mojo/runner/in_process_native_runner.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
anujsharma
PTAL
5 years, 7 months ago (2015-04-29 13:30:39 UTC) #2
anujsharma
On 2015/04/29 13:30:39, anujsharma wrote: > PTAL @SKY could you please take a look. Thanks!!
5 years, 7 months ago (2015-05-01 14:50:03 UTC) #3
sky
https://codereview.chromium.org/1118473002/diff/1/mojo/common/handle_watcher.cc File mojo/common/handle_watcher.cc (right): https://codereview.chromium.org/1118473002/diff/1/mojo/common/handle_watcher.cc#newcode54 mojo/common/handle_watcher.cc:54: scoped_refptr<base::SingleThreadTaskRunner> message_loop; Rename this.
5 years, 7 months ago (2015-05-01 15:21:53 UTC) #4
anujsharma
Thanks sky four your comments!! Changes are done. Could you please take a look now. ...
5 years, 7 months ago (2015-05-04 06:56:39 UTC) #5
sky
LGTM
5 years, 7 months ago (2015-05-04 15:21:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118473002/20001
5 years, 7 months ago (2015-05-04 15:27:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/33743) linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-05-04 15:35:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118473002/40001
5 years, 7 months ago (2015-05-05 10:51:50 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-05 12:01:06 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/332a1b2b1d5635199d5ed453f5f9586b2e030b64 Cr-Commit-Position: refs/heads/master@{#328311}
5 years, 7 months ago (2015-05-05 12:02:12 UTC) #15
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-05 12:15:09 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1125913002/ by jochen@chromium.org.

The reason for reverting is: breaks compilation on win gn
https://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/6922.

Powered by Google App Engine
This is Rietveld 408576698