Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1118433002: [test] Remove deprecated GraphTester helper class. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-test-node-cache
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Remove deprecated GraphTester helper class. R=bmeurer@chromium.org TEST=cctest/test-node Committed: https://crrev.com/de88984334ef0f215e826e0fedd419b8e6d05f22 Cr-Commit-Position: refs/heads/master@{#28138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -46 lines) Patch
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D test/cctest/compiler/graph-tester.h View 1 chunk +0 lines, -27 lines 0 comments Download
M test/cctest/compiler/test-node.cc View 18 chunks +36 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 7 months ago (2015-04-29 11:40:13 UTC) #1
Benedikt Meurer
LGTM, yay!
5 years, 7 months ago (2015-04-29 11:41:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118433002/1
5 years, 7 months ago (2015-04-29 15:00:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 15:16:10 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 15:16:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de88984334ef0f215e826e0fedd419b8e6d05f22
Cr-Commit-Position: refs/heads/master@{#28138}

Powered by Google App Engine
This is Rietveld 408576698