Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 11184054: mac: Fix building with xcodebuild on Xcode4.4 (Closed)

Created:
8 years, 2 months ago by Nico
Modified:
8 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, Lambros
Visibility:
Public.

Description

mac: Fix building with xcodebuild on Xcode4.4 See the bug for details. BUG=156530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162859

Patch Set 1 #

Total comments: 2

Patch Set 2 : ungrammatical #

Patch Set 3 : coming on #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/common.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nico
The -Wno-arc-abi warning issue I mention on the bug is apparently new in Xcode 4.5. ...
8 years, 2 months ago (2012-10-18 22:08:14 UTC) #1
Mark Mentovai
https://codereview.chromium.org/11184054/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/11184054/diff/1/build/common.gypi#newcode2979 build/common.gypi:2979: # We don't want libarclite_macosx.a, see http://crbug.com/156530. “We?”
8 years, 2 months ago (2012-10-18 22:16:01 UTC) #2
Nico
https://codereview.chromium.org/11184054/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/11184054/diff/1/build/common.gypi#newcode2979 build/common.gypi:2979: # We don't want libarclite_macosx.a, see http://crbug.com/156530. On 2012/10/18 ...
8 years, 2 months ago (2012-10-18 22:21:02 UTC) #3
Mark Mentovai
Come on.
8 years, 2 months ago (2012-10-18 22:25:22 UTC) #4
Nico
Changed again. What will it say this time? On Thu, Oct 18, 2012 at 3:25 ...
8 years, 2 months ago (2012-10-18 22:27:37 UTC) #5
Mark Mentovai
lgtm
8 years, 2 months ago (2012-10-18 22:38:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/11184054/9001
8 years, 2 months ago (2012-10-18 22:40:30 UTC) #7
commit-bot: I haz the power
8 years, 2 months ago (2012-10-19 00:12:32 UTC) #8
Sorry for I got bad news for ya.
Compile failed with a clobber build.
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698