Adds GN rule & script for generating AndroidManifest.xml for APK splits

Adds GN rule & script for generating AndroidManifest.xml for APK splits

Build rule is not hooked up to any targets yet, but will be used in a
future commit to create split APKs.

.gypi also forthcoming.

BUG=447152
Committed: https://crrev.com/81cc62af7059b65fe7d4d6dfd420f7cacd03ddc9
Cr-Commit-Position: refs/heads/master@{#329850}

[agrieve, 2015-05-05 19:27:56]

agrieve@chromium.org changed reviewers:
+ sadrul@chromium.org

[agrieve, 2015-05-05 19:27:56]

Working on adapting create_apk use this, but thought it'd be a good piece on
it's own to commit.

[sadrul, 2015-05-06 14:45:00]

Nice! From my limited understanding of python and manifests, this looks good
(nit: copyright should be 2015 instead of 2013). But I have no readability or
authoritah here :) Perhaps Yaron could suggest a better reviewer?

[jbudorick, 2015-05-06 14:53:43]

jbudorick@chromium.org changed reviewers:
+ cjhopman@chromium.org, jbudorick@chromium.org

[jbudorick, 2015-05-06 14:53:44]

+cjhopman

[Yaron, 2015-05-06 14:56:19]

On 2015/05/06 14:53:44, jbudorick wrote:
> +cjhopman

Ya, cjhopman is a much better reviewer for this :)

[cjhopman, 2015-05-07 00:39:53]

https://codereview.chromium.org/1118403004/diff/1/build/android/gyp/generate_...
File build/android/gyp/generate_split_manifest.py (right):

https://codereview.chromium.org/1118403004/diff/1/build/android/gyp/generate_...
build/android/gyp/generate_split_manifest.py:112:
build_utils.GetPythonDependencies())
This list should include the path to the main manifest

https://codereview.chromium.org/1118403004/diff/1/build/config/android/intern...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1118403004/diff/1/build/config/android/intern...
build/config/android/internal_rules.gni:1195: "${invoker.has_code}",
this should be like the previous two

[agrieve, 2015-05-12 17:51:44]

Also removed versionCode logic, since that gets inserted by the
package_resources step.

https://codereview.chromium.org/1118403004/diff/1/build/android/gyp/generate_...
File build/android/gyp/generate_split_manifest.py (right):

https://codereview.chromium.org/1118403004/diff/1/build/android/gyp/generate_...
build/android/gyp/generate_split_manifest.py:112:
build_utils.GetPythonDependencies())
On 2015/05/07 00:39:52, cjhopman wrote:
> This list should include the path to the main manifest

Done.

[agrieve, 2015-05-12 19:17:13]

On 2015/05/12 17:51:44, agrieve wrote:
> Also removed versionCode logic, since that gets inserted by the
> package_resources step.
> 
>
https://codereview.chromium.org/1118403004/diff/1/build/android/gyp/generate_...
> File build/android/gyp/generate_split_manifest.py (right):
> 
>
https://codereview.chromium.org/1118403004/diff/1/build/android/gyp/generate_...
> build/android/gyp/generate_split_manifest.py:112:
> build_utils.GetPythonDependencies())
> On 2015/05/07 00:39:52, cjhopman wrote:
> > This list should include the path to the main manifest
> 
> Done.

Added aiolos@chromium.org, dtu@chromium.org, nednguyen@google.com, since tryjob
(patch set 2) got the following:

AssertionError: Your patch adds new dependencies to telemetry. Please contact
aiolos@,dtu@, or nednguyen@ on how to proceed with this change

Seems to be from:
/src/tools/telemetry/telemetry/telemetry_dependencies_unittest.py

[nednguyen, 2015-05-12 21:32:12]

On 2015/05/12 19:17:13, agrieve wrote:
> On 2015/05/12 17:51:44, agrieve wrote:
> > Also removed versionCode logic, since that gets inserted by the
> > package_resources step.
> > 
> >
>
https://codereview.chromium.org/1118403004/diff/1/build/android/gyp/generate_...
> > File build/android/gyp/generate_split_manifest.py (right):
> > 
> >
>
https://codereview.chromium.org/1118403004/diff/1/build/android/gyp/generate_...
> > build/android/gyp/generate_split_manifest.py:112:
> > build_utils.GetPythonDependencies())
> > On 2015/05/07 00:39:52, cjhopman wrote:
> > > This list should include the path to the main manifest
> > 
> > Done.
> 
> Added mailto:aiolos@chromium.org, mailto:dtu@chromium.org,
mailto:nednguyen@google.com, since tryjob
> (patch set 2) got the following:
> 
> AssertionError: Your patch adds new dependencies to telemetry. Please contact
> aiolos@,dtu@, or nednguyen@ on how to proceed with this change
> 
> Seems to be from:
> /src/tools/telemetry/telemetry/telemetry_dependencies_unittest.py

lgtm if you need telemetry stamp

[agrieve, 2015-05-13 13:49:32]

On 2015/05/12 21:32:12, nednguyen (slow review) wrote:
> On 2015/05/12 19:17:13, agrieve wrote:
> > On 2015/05/12 17:51:44, agrieve wrote:
> > > Also removed versionCode logic, since that gets inserted by the
> > > package_resources step.
> > > 
> > >
> >
>
https://codereview.chromium.org/1118403004/diff/1/build/android/gyp/generate_...
> > > File build/android/gyp/generate_split_manifest.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1118403004/diff/1/build/android/gyp/generate_...
> > > build/android/gyp/generate_split_manifest.py:112:
> > > build_utils.GetPythonDependencies())
> > > On 2015/05/07 00:39:52, cjhopman wrote:
> > > > This list should include the path to the main manifest
> > > 
> > > Done.
> > 
> > Added mailto:aiolos@chromium.org, mailto:dtu@chromium.org,
> mailto:nednguyen@google.com, since tryjob
> > (patch set 2) got the following:
> > 
> > AssertionError: Your patch adds new dependencies to telemetry. Please
contact
> > aiolos@,dtu@, or nednguyen@ on how to proceed with this change
> > 
> > Seems to be from:
> > /src/tools/telemetry/telemetry/telemetry_dependencies_unittest.py
> 
> lgtm if you need telemetry stamp

Thanks @cjhopman - PTAL

[cjhopman, 2015-05-14 00:24:41]

lgtm

https://codereview.chromium.org/1118403004/diff/60001/build/config/android/in...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1118403004/diff/60001/build/config/android/in...
build/config/android/internal_rules.gni:1219: action(target_name) {
nit: for templates that consist of a single action, I think it's best for
everything to be done within that action (that is, move this line to the
beginning of the template).

[agrieve, 2015-05-14 13:51:46]

https://codereview.chromium.org/1118403004/diff/60001/build/config/android/in...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/1118403004/diff/60001/build/config/android/in...
build/config/android/internal_rules.gni:1219: action(target_name) {
On 2015/05/14 00:24:41, cjhopman wrote:
> nit: for templates that consist of a single action, I think it's best for
> everything to be done within that action (that is, move this line to the
> beginning of the template).

Done.

[agrieve, 2015-05-14 13:52:00]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-05-14 13:52:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
cjhopman@chromium.org, nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1118403004/#ps80001
(title: "Tweaked generate_split_manifest GN template so that action is at top")

[commit-bot: I haz the power, 2015-05-14 13:52:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1118403004/80001

[commit-bot: I haz the power, 2015-05-14 15:03:50]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-14 15:04:29]

Patchset 5 (id:??) landed as
https://crrev.com/81cc62af7059b65fe7d4d6dfd420f7cacd03ddc9
Cr-Commit-Position: refs/heads/master@{#329850}