Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 11184028: Pull in mtpd from CrOS and add files to build it on Linux. (Closed)

Created:
8 years, 2 months ago by Lei Zhang
Modified:
8 years, 2 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Pull in mtpd from CrOS and add files to build it on Linux. BUG=151685 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163172

Patch Set 1 : #

Total comments: 4

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+406 lines, -0 lines) Patch
M DEPS View 1 1 chunk +5 lines, -0 lines 0 comments Download
M build/all.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/mtpd/README.chromium View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/mtpd/mtpd.gyp View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/mtpd/mtpd_server/mtpd_server.h View 1 chunk +342 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
8 years, 2 months ago (2012-10-17 21:24:47 UTC) #1
Ryan Sleevi
https://codereview.chromium.org/11184028/diff/2001/third_party/mtpd/README.chromium File third_party/mtpd/README.chromium (right): https://codereview.chromium.org/11184028/diff/2001/third_party/mtpd/README.chromium#newcode5 third_party/mtpd/README.chromium:5: License File: ../../LICENSE.chromium_os Does this work for the license ...
8 years, 2 months ago (2012-10-17 22:12:29 UTC) #2
Lei Zhang
https://codereview.chromium.org/11184028/diff/2001/third_party/mtpd/README.chromium File third_party/mtpd/README.chromium (right): https://codereview.chromium.org/11184028/diff/2001/third_party/mtpd/README.chromium#newcode5 third_party/mtpd/README.chromium:5: License File: ../../LICENSE.chromium_os On 2012/10/17 22:12:29, Ryan Sleevi wrote: ...
8 years, 2 months ago (2012-10-17 22:36:27 UTC) #3
Ryan Sleevi
lgtm
8 years, 2 months ago (2012-10-17 22:38:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11184028/2001
8 years, 2 months ago (2012-10-18 05:57:03 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build. Your ...
8 years, 2 months ago (2012-10-18 06:08:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11184028/2001
8 years, 2 months ago (2012-10-20 17:06:51 UTC) #7
commit-bot: I haz the power
Presubmit check for 11184028-2001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-20 17:06:58 UTC) #8
darin (slow to review)
8 years, 2 months ago (2012-10-20 18:21:03 UTC) #9
LGTM

On 2012/10/20 17:06:58, I haz the power (commit-bot) wrote:
> Presubmit check for 11184028-2001 failed and returned exit status 1.
> 
> 
> Running presubmit commit checks ...
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for files in these directories:
>     
> 
> Presubmit checks took 3.4s to calculate.

Powered by Google App Engine
This is Rietveld 408576698