Issue 11184012: delegate_execute should build on 2012 too

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11184012: delegate_execute should build on 2012 too (Closed)

Created:
8 years, 2 months ago by scottmg

Modified:
8 years, 2 months ago

Reviewers:
cpu_(ooo_6.6-7.5), Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

delegate_execute should build on 2012 too Just removing condition because 2008 is toast. BUG=143646 R=cpu@chromium.org TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162280

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/chrome_exe.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	win8/metro_driver/metro_driver.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

lgtm On Tue, Oct 16, 2012 at 4:09 PM, <scottmg@chromium.org> wrote: > https://codereview.chromium.**org/11184012/<https://codereview.chromium.org/11184012/> >

8 years, 2 months ago (2012-10-16 23:15:01 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/11184012/1

8 years, 2 months ago (2012-10-16 23:20:31 UTC) #4

lgtm

Expand Messages | Collapse Messages