Shut down RenderViewTest's scheduler before Blink is.

Shut down RenderViewTest's scheduler before Blink is.

As the former may finalize tasks that are Blink allocated.

R=skyostil,haraken,jochen
BUG=420515
Committed: https://crrev.com/8c57425ac0b275974b6e3477bad5a4736853ccd3
Cr-Commit-Position: refs/heads/master@{#328107}

[sof, 2015-05-01 20:01:03]

sigbjornf@opera.com changed reviewers:
+ jochen@chromium.org, oilpan-reviews@chromium.org, skyostil@chromium.org

[sof, 2015-05-01 20:01:04]

please take a look.

Addresses crashes causing this revert,

 https://codereview.chromium.org/1123443002/

This one should have been caught&addressed as part of
https://codereview.chromium.org/1054893002/ , but wasn't unfortunately.

[Sami, 2015-05-01 20:46:31]

lgtm, thanks for the fix.

https://codereview.chromium.org/1118383002/diff/1/content/public/test/render_...
File content/public/test/render_view_test.cc (right):

https://codereview.chromium.org/1118383002/diff/1/content/public/test/render_...
content/public/test/render_view_test.cc:288:
blink_platform_impl_.Scheduler()->Shutdown();
This is a good idea since it matches what we do in production code:

https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/r...

https://codereview.chromium.org/1118383002/diff/1/content/public/test/render_...
File content/public/test/render_view_test.h (right):

https://codereview.chromium.org/1118383002/diff/1/content/public/test/render_...
content/public/test/render_view_test.h:57: scheduler::RendererScheduler*
Scheduler();
nit: this could be a const method.

[sof, 2015-05-01 20:59:27]

https://codereview.chromium.org/1118383002/diff/1/content/public/test/render_...
File content/public/test/render_view_test.h (right):

https://codereview.chromium.org/1118383002/diff/1/content/public/test/render_...
content/public/test/render_view_test.h:57: scheduler::RendererScheduler*
Scheduler();
On 2015/05/01 20:46:31, Sami wrote:
> nit: this could be a const method.

Done (for Scheduler() and Get().)

[haraken, 2015-05-02 02:30:34]

LGTM

[sof, 2015-05-02 05:02:41]

jochen@: owner look? tia.

[jochen (gone - plz use gerrit), 2015-05-04 07:26:31]

jochen@chromium.org changed reviewers:
+ haraken@chromium.org

[jochen (gone - plz use gerrit), 2015-05-04 07:26:32]

lgtm

[sof, 2015-05-04 07:31:10]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-05-04 07:31:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/1118383002/#ps20001
(title: "const'ify getters")

[commit-bot: I haz the power, 2015-05-04 07:31:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1118383002/20001

[commit-bot: I haz the power, 2015-05-04 09:05:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-04 09:06:26]

Patchset 2 (id:??) landed as
https://crrev.com/8c57425ac0b275974b6e3477bad5a4736853ccd3
Cr-Commit-Position: refs/heads/master@{#328107}