Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 1118373006: Revert of Load and apply a vcgt table from an ICC file to the internal display (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, kalyank, oshima+watch_chromium.org, ozone-reviews_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Load and apply a vcgt table from an ICC file to the internal display (patchset #15 id:300001 of https://codereview.chromium.org/1028563003/) Reason for revert: breaks compilation https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN%20(dbg)/builds/1084 Original issue's description: > Load and apply a vcgt table from an ICC file to the internal display > > When the command line switch --internal-display-color-profile-file is provided > load the given ICC file using qcms and extract the VCGT data. Use this VCGT > data to apply a gamma ramp to change the output on the internal display using > drmModeCrtcSetGammaRamp. > > BUG=471749 > TEST=On a link_freon device add the command line option to load a sample ICC > file (e.g. Bluish.icc to give a blue tint) and observe on startup that the > internal display is blue tinted. > > Committed: https://crrev.com/46134a86af1eac76e97b062a68afeaa6c8801216 > Cr-Commit-Position: refs/heads/master@{#328318} TBR=dcheng@chromium.org,dnicoara@chromium.org,noel@chromium.org,oshima@chromium.org,sievers@chromium.org,spang@chromium.org,robert.bradford@intel.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471749 Committed: https://crrev.com/e005ecc8ce2f29011df0dad07ccfd7eb2d61c207 Cr-Commit-Position: refs/heads/master@{#328321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -410 lines) Patch
M ash/ash.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M ash/content/display/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
D ash/content/display/display_color_manager_chromeos.h View 1 chunk +0 lines, -66 lines 0 comments Download
D ash/content/display/display_color_manager_chromeos.cc View 1 chunk +0 lines, -139 lines 0 comments Download
M ash/shell.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/shell.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/display/chromeos/display_configurator.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/display/chromeos/display_configurator.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M ui/display/chromeos/test/action_logger_util.h View 3 chunks +0 lines, -5 lines 0 comments Download
M ui/display/chromeos/test/action_logger_util.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M ui/display/chromeos/test/test_native_display_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/display/chromeos/test/test_native_display_delegate.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/display/display.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/display/types/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D ui/display/types/gamma_ramp_rgb_entry.h View 1 chunk +0 lines, -23 lines 0 comments Download
M ui/display/types/native_display_delegate.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/ozone/common/gpu/ozone_gpu_messages.h View 3 chunks +0 lines, -12 lines 0 comments Download
M ui/ozone/common/native_display_delegate_ozone.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/ozone/common/native_display_delegate_ozone.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 2 chunks +0 lines, -29 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_display_manager.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_platform_support.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_gpu_platform_support.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_native_display_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_native_display_delegate.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/ozone/platform/drm/test/mock_drm_device.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/test/mock_drm_device.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Load and apply a vcgt table from an ICC file to the ...
5 years, 7 months ago (2015-05-05 13:47:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118373006/1
5 years, 7 months ago (2015-05-05 13:48:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 13:49:30 UTC) #3
Noel Gordon
LGTM
5 years, 7 months ago (2015-05-05 14:03:40 UTC) #4
Noel Gordon
... [1532/1556] LINK ./extensions_unittests [1533/1556] STAMP obj/extensions/shell/app_shell_lib.stamp [1534/1556] LINK ./extensions_browsertests [1535/1556] SOLINK ./libash.so [1536/1556] AR ...
5 years, 7 months ago (2015-05-05 14:04:37 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 14:18:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e005ecc8ce2f29011df0dad07ccfd7eb2d61c207
Cr-Commit-Position: refs/heads/master@{#328321}

Powered by Google App Engine
This is Rietveld 408576698