src/IceTargetLoweringX8632.cpp - Issue 1118353005: Subzero: Use a setcc sequence for better icmp lowering.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8632.cpp

Issue 1118353005: Subzero: Use a setcc sequence for better icmp lowering. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Cleanup Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX8632.cpp

diff --git a/src/IceTargetLoweringX8632.cpp b/src/IceTargetLoweringX8632.cpp

index 582e441d33b488b3fc7ee8cdee367e54d550d515..399d05826e0a869b5b1d99d55357557676d841d1 100644

--- a/src/IceTargetLoweringX8632.cpp

+++ b/src/IceTargetLoweringX8632.cpp

@@ -2748,12 +2748,8 @@ void TargetX8632::lowerIcmp(const InstIcmp *Inst) {

// cmp b, c

Operand *Src0RM =

legalize(Src0, IsSrc1ImmOrReg ? (Legal_Reg | Legal_Mem) : Legal_Reg);

- InstX8632Label *Label = InstX8632Label::create(Func, this);

_cmp(Src0RM, Src1);

- _mov(Dest, One);

- _br(getIcmp32Mapping(Inst->getCondition()), Label);

- _mov_nonkillable(Dest, Zero);

- Context.insert(Label);

+ _setcc(Dest, getIcmp32Mapping(Inst->getCondition()));

}

void TargetX8632::lowerInsertElement(const InstInsertElement *Inst) {

« no previous file with comments | « src/IceTargetLoweringX8632.h ('k') | src/assembler_ia32.h » ('j') | no next file with comments »