Source/platform/fonts/Font.h - Issue 111833006: Avoiding multiple text/string parsing while creating TextRun

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/Font.h

Issue 111833006: Avoiding multiple text/string parsing while creating TextRun (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@FontOptPatch1

Patch Set: Fixing review comments for rebasing files Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/fonts/Font.h

diff --git a/Source/platform/fonts/Font.h b/Source/platform/fonts/Font.h

index 1e1e4961746db0f0c09234a71505ff96ba366442..b28b90b67cdbdab6c302f09aa533d6bfe3f461f9 100644

--- a/Source/platform/fonts/Font.h

+++ b/Source/platform/fonts/Font.h

@@ -162,9 +162,8 @@ public:

static void setShouldUseSmoothing(bool);

static bool shouldUseSmoothing();

- enum CodePath { Auto, Simple, Complex, SimpleWithGlyphOverflow };

CodePath codePath(const TextRun&) const;

- static CodePath characterRangeCodePath(const LChar*, unsigned) { return Simple; }

+ static CodePath characterRangeCodePath(const LChar*, unsigned) { return SimplePath; }

static CodePath characterRangeCodePath(const UChar*, unsigned len);

private:

« Source/core/rendering/svg/SVGTextMetricsBuilder.cpp ('K') | « Source/platform/blink_platform.gypi ('k') | Source/platform/fonts/Font.cpp » ('j') | Source/platform/fonts/Font.cpp » ('J')