Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Side by Side Diff: chrome/browser/resources/file_manager/foreground/js/ui/search_box.js

Issue 111833002: Add missing argument to Element.setAttribute() calls (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 'use strict'; 5 'use strict';
6 6
7 /** 7 /**
8 * Search box. 8 * Search box.
9 * 9 *
10 * @param {element} element Root element of the search box. 10 * @param {element} element Root element of the search box.
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 var li = new cr.ui.ListItem(); 110 var li = new cr.ui.ListItem();
111 li.itemInfo = item; 111 li.itemInfo = item;
112 112
113 var icon = document.createElement('div'); 113 var icon = document.createElement('div');
114 icon.className = 'detail-icon'; 114 icon.className = 'detail-icon';
115 115
116 var text = document.createElement('div'); 116 var text = document.createElement('div');
117 text.className = 'detail-text'; 117 text.className = 'detail-text';
118 118
119 if (item.isHeaderItem) { 119 if (item.isHeaderItem) {
120 icon.setAttribute('search-icon'); 120 icon.setAttribute('search-icon', '');
121 text.innerHTML = 121 text.innerHTML =
122 strf('SEARCH_DRIVE_HTML', util.htmlEscape(item.searchQuery)); 122 strf('SEARCH_DRIVE_HTML', util.htmlEscape(item.searchQuery));
123 } else { 123 } else {
124 var iconType = FileType.getIcon(item.entry); 124 var iconType = FileType.getIcon(item.entry);
125 icon.setAttribute('file-type-icon', iconType); 125 icon.setAttribute('file-type-icon', iconType);
126 // highlightedBaseName is a piece of HTML with meta characters properly 126 // highlightedBaseName is a piece of HTML with meta characters properly
127 // escaped. See the comment at fileBrowserPrivate.searchDriveMetadata(). 127 // escaped. See the comment at fileBrowserPrivate.searchDriveMetadata().
128 text.innerHTML = item.highlightedBaseName; 128 text.innerHTML = item.highlightedBaseName;
129 } 129 }
130 li.appendChild(icon); 130 li.appendChild(icon);
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 * Updates styles of the search box. 193 * Updates styles of the search box.
194 * @private 194 * @private
195 */ 195 */
196 SearchBox.prototype.updateStyles_ = function() { 196 SearchBox.prototype.updateStyles_ = function() {
197 this.element.classList.toggle('has-text', 197 this.element.classList.toggle('has-text',
198 !!this.inputElement.value); 198 !!this.inputElement.value);
199 var width = this.textMeasure_.getWidth(this.inputElement.value) + 199 var width = this.textMeasure_.getWidth(this.inputElement.value) +
200 16 /* Extra space to allow leeway. */; 200 16 /* Extra space to allow leeway. */;
201 this.inputElement.style.width = width + 'px'; 201 this.inputElement.style.width = width + 'px';
202 }; 202 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698