Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issue 111833002: Add missing argument to Element.setAttribute() calls (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
Reviewers:
binji, Evan Stade
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, binji, arv+watch_chromium.org, Sam Clegg
Visibility:
Public.

Description

Add missing argument to Element.setAttribute() calls "Make arguments to Element methods non-optional" was reverted in Blink because these tests began failing. BUG=325922 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239999

Patch Set 1 #

Messages

Total messages: 6 (0 generated)
philipj_slow
7 years ago (2013-12-10 22:06:11 UTC) #1
binji
native_client_sdk lgtm, thanks!
7 years ago (2013-12-10 22:12:41 UTC) #2
sky
I'm not a good owner here. sky->estade
7 years ago (2013-12-10 22:54:41 UTC) #3
Evan Stade
lgtm
7 years ago (2013-12-10 23:23:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/111833002/1
7 years ago (2013-12-10 23:42:54 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-11 03:41:22 UTC) #6
Message was sent while issue was closed.
Change committed as 239999

Powered by Google App Engine
This is Rietveld 408576698