Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: lib/compiler/implementation/elements/elements.dart

Issue 11183053: Remove VariableScope, Scope.lexicalLookup and Scope.inStaticContext (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comment Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/resolution/members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/elements/elements.dart
diff --git a/lib/compiler/implementation/elements/elements.dart b/lib/compiler/implementation/elements/elements.dart
index 6b77e71cf8e89f271c65f71ebc54af64846f58de..4297c8bf0fb54fc8cc49d98f72c3f705cf514a90 100644
--- a/lib/compiler/implementation/elements/elements.dart
+++ b/lib/compiler/implementation/elements/elements.dart
@@ -948,17 +948,6 @@ class VariableListElement extends Element {
bool isInstanceMember() {
return isMember() && !modifiers.isStatic();
}
-
- // TODO(johnniwinther): Rewrite to avoid the optional argument.
- Scope buildScope({bool patchScope: false}) {
- Scope result = new VariableScope(
- enclosingElement.buildScope(patchScope: patchScope), this);
- if (enclosingElement.isClass()) {
- Scope clsScope = result.parent;
- clsScope.inStaticContext = !isInstanceMember();
- }
- return result;
- }
}
class ForeignElement extends Element {
@@ -1206,17 +1195,6 @@ class FunctionElement extends Element {
return super.toString();
}
}
-
- // TODO(johnniwinther): Rewrite to avoid the optional argument.
- Scope buildScope({bool patchScope: false}) {
- Scope result = new MethodScope(
- enclosingElement.buildScope(patchScope: patchScope), this);
- if (enclosingElement.isClass()) {
- Scope clsScope = result.parent;
- clsScope.inStaticContext = !isInstanceMember() && !isConstructor();
- }
- return result;
- }
}
class ConstructorBodyElement extends FunctionElement {
« no previous file with comments | « no previous file | lib/compiler/implementation/resolution/members.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698