Don't reject extension list policies with invalid entries.

chrome/browser/policy/configuration_policy_handler_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/configuration_policy_handler.h"
 #include "chrome/browser/policy/policy_error_map.h"
 #include "chrome/browser/policy/policy_map.h"
 #include "chrome/browser/prefs/pref_value_map.h"
 #include "chrome/common/pref_names.h"
 #include "policy/policy_constants.h"
@@ skipping 26 matching lines @@
   policy_map.Set(key::kExtensionInstallBlacklist, POLICY_LEVEL_MANDATORY,
                  POLICY_SCOPE_USER, list.DeepCopy());
   errors.Clear();
   EXPECT_TRUE(handler.CheckPolicySettings(policy_map, &errors));
   EXPECT_TRUE(errors.empty());
 
   list.Append(Value::CreateStringValue("invalid"));
   policy_map.Set(key::kExtensionInstallBlacklist, POLICY_LEVEL_MANDATORY,
                  POLICY_SCOPE_USER, list.DeepCopy());
   errors.Clear();
-  EXPECT_FALSE(handler.CheckPolicySettings(policy_map, &errors));
+  EXPECT_TRUE(handler.CheckPolicySettings(policy_map, &errors));
   EXPECT_FALSE(errors.empty());
   EXPECT_FALSE(errors.GetErrors(key::kExtensionInstallBlacklist).empty());
 }
 
 TEST(ExtensionListPolicyHandlerTest, ApplyPolicySettings) {
-  base::ListValue list;
+  base::ListValue policy;
+  base::ListValue expected;
   PolicyMap policy_map;
   PrefValueMap prefs;
   base::Value* value = NULL;
   ExtensionListPolicyHandler handler(key::kExtensionInstallBlacklist,
                                      prefs::kExtensionInstallDenyList,
                                      false);
 
-  list.Append(Value::CreateStringValue("abcdefghijklmnopabcdefghijklmnop"));
+  policy.Append(Value::CreateStringValue("abcdefghijklmnopabcdefghijklmnop"));
+  expected.Append(Value::CreateStringValue("abcdefghijklmnopabcdefghijklmnop"));
+
   policy_map.Set(key::kExtensionInstallBlacklist, POLICY_LEVEL_MANDATORY,
-                 POLICY_SCOPE_USER, list.DeepCopy());
+                 POLICY_SCOPE_USER, policy.DeepCopy());
   handler.ApplyPolicySettings(policy_map, &prefs);
   EXPECT_TRUE(prefs.GetValue(prefs::kExtensionInstallDenyList, &value));
-  EXPECT_TRUE(base::Value::Equals(&list, value));
+  EXPECT_TRUE(base::Value::Equals(&expected, value));
+
+  policy.Append(Value::CreateStringValue("invalid"));
+  policy_map.Set(key::kExtensionInstallBlacklist, POLICY_LEVEL_MANDATORY,
+                 POLICY_SCOPE_USER, policy.DeepCopy());
+  handler.ApplyPolicySettings(policy_map, &prefs);
+  EXPECT_TRUE(prefs.GetValue(prefs::kExtensionInstallDenyList, &value));
+  EXPECT_TRUE(base::Value::Equals(&expected, value));
 }
 
 TEST(ExtensionURLPatternListPolicyHandlerTest, CheckPolicySettings) {
   base::ListValue list;
   PolicyMap policy_map;
   PolicyErrorMap errors;
   ExtensionURLPatternListPolicyHandler handler(
       key::kExtensionInstallSources,
       prefs::kExtensionAllowedInstallSites);
 
@@ skipping 100 matching lines @@
   ASSERT_TRUE(prefs.GetValue(prefs::kManagedDefaultCookiesSetting, &val));
   EXPECT_TRUE(base::FundamentalValue(CONTENT_SETTING_SESSION_ONLY).Equals(val));
 
   policy_map.Clear();
   prefs.Clear();
   handler.ApplyPolicySettings(policy_map, &prefs);
   EXPECT_FALSE(prefs.GetValue(prefs::kManagedDefaultCookiesSetting, &val));
 }
 
 }  // namespace policy