Issue 11183017: libmtp: Cherrypick upstream commit 15d18e31458be5006eb229df68869df2fff9 to fix device detection for…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11183017: libmtp: Cherrypick upstream commit 15d18e31458be5006eb229df68869df2fff9 to fix device detection for… (Closed)

Created:
8 years, 2 months ago by Lei Zhang

Modified:
8 years, 2 months ago

Reviewers:
Jorge Lucangeli Obes

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/deps/third_party/libmtp/

Visibility:
Public.

More Reviews

Description

libmtp: Cherrypick upstream commit 15d18e31458be5006eb229df68869df2fff9 to fix device detection for some Android devices. BUG=156143 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162285

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+478 lines, -75 lines)			Patch
A	patches/13_cherrypick_15d18e31.patch	View	1 chunk	+351 lines, -0 lines	0 comments	Download
M	src/libusb-glue.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/libusb1-glue.c	View	9 chunks	+124 lines, -74 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

jorgelo: I have a tablet that does not work on CrOS M23. I noticed upstream ...

8 years, 2 months ago (2012-10-16 23:29:41 UTC) #1

Jorge Lucangeli Obes

8 years, 2 months ago (2012-10-16 23:33:46 UTC) #2

On 2012/10/16 23:29:41, Lei Zhang wrote:
> jorgelo: I have a tablet that does not work on CrOS M23. I noticed upstream
> libmtp has fixed the bug, so I'm cherrypicking their fix here and then I'll
try
> to merge to M23. With this patch, all my test devices work.
> 
> The upstream commit fixes all the different libusb implementations. I'm only
> cherrypicking the changes to the one we use.
> 
> After this I'll update libmtp to the newest release that includes this patch.

You and your crazy tablets =P

lgtm

Expand Messages | Collapse Messages