Removing "WinHttpGetProxyForUrl failed" message.

Removing "WinHttpGetProxyForUrl failed" message.

WinHttpGetProxyForUrl() can fail in some network configurations. For example it often fails when running in a home network when it cannot download the PAC script. In other words it is normal for this function to fail and the calling cade should just be able to handle it (which is does already).

BUG=156135
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162220

[alexeypa (please no reviews), 2012-10-16 18:23:36]

PTAL.

[willchan no longer on Chromium, 2012-10-16 18:27:44]

+eroman

I'm surprised to see us use this still. I'm redirecting to Eric, he
says we don't use it in Chrome proper, although maybe this user is
triggering it somehow. In any case, removing the ERROR message seems
fine.

On Tue, Oct 16, 2012 at 11:23 AM,  <alexeypa@chromium.org> wrote:
> Reviewers: willchan,
>
> Message:
> PTAL.
>
> Description:
> Removing "WinHttpGetProxyForUrl failed" message.
>
> WinHttpGetProxyForUrl() can fail in some network configurations. For example
> it
> often fails when running in a home network when it cannot download the PAC
> script. In other words it is normal for this function to fail and the
> calling
> cade should just be able to handle it (which is does already).
>
> BUG=156135
>
>
> Please review this at https://codereview.chromium.org/11183007/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M net/proxy/proxy_resolver_winhttp.cc
>
>
> Index: net/proxy/proxy_resolver_winhttp.cc
> diff --git a/net/proxy/proxy_resolver_winhttp.cc
> b/net/proxy/proxy_resolver_winhttp.cc
> index
>
46665fc815fcb650b18314e8bfe377f9ce0ba3df..1e14fbb51bf1252c33c385c2a0e10d9e0104e75b
> 100644
> --- a/net/proxy/proxy_resolver_winhttp.cc
> +++ b/net/proxy/proxy_resolver_winhttp.cc
> @@ -76,7 +76,6 @@ int ProxyResolverWinHttp::GetProxyForURL(const GURL&
> query_url,
>      }
>      if (!ok) {
>        DWORD error = GetLastError();
> -      LOG(ERROR) << "WinHttpGetProxyForUrl failed: " << error;
>        // If we got here because of RPC timeout during out of process PAC
>        // resolution, no further requests on this session are going to work.
>        if (ERROR_WINHTTP_TIMEOUT == error ||
>
>

[alexeypa (please no reviews), 2012-10-16 18:29:12]

On 2012/10/16 18:27:44, willchan wrote:
> +eroman
> 
> I'm surprised to see us use this still. I'm redirecting to Eric, he
> says we don't use it in Chrome proper, although maybe this user is
> triggering it somehow. In any case, removing the ERROR message seems
> fine.

One clarification. We see it in Chromoting Host logs, not in Chrome.

[willchan no longer on Chromium, 2012-10-16 18:30:38]

That makes sense. LGTM. eroman@, feel free to review if you want.

On Tue, Oct 16, 2012 at 11:29 AM,  <alexeypa@chromium.org> wrote:
> On 2012/10/16 18:27:44, willchan wrote:
>>
>> +eroman
>
>
>> I'm surprised to see us use this still. I'm redirecting to Eric, he
>> says we don't use it in Chrome proper, although maybe this user is
>> triggering it somehow. In any case, removing the ERROR message seems
>> fine.
>
>
> One clarification. We see it in Chromoting Host logs, not in Chrome.
>
> https://codereview.chromium.org/11183007/

[eroman, 2012-10-16 19:24:26]

LGTM.

Chrome doesn't use this, other than in single process mode. It seems there are
some other consumers that have began using it, which is unfortunate.