Simple CL to add a joinWithPossiblyEmptyArg to SkRect

Simple CL to add a joinWithPossiblyEmptyArg to SkRect

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/3dc2ccae6c0f0cf6ac951585a197bfb8a58cfee5

[joshualitt, 2015-05-01 15:01:10]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, reed@google.com

[joshualitt, 2015-05-01 15:01:11]

ptal

[reed1, 2015-05-01 15:44:40]

lgtm w/ nit

https://codereview.chromium.org/1118293002/diff/1/include/core/SkRect.h
File include/core/SkRect.h (right):

https://codereview.chromium.org/1118293002/diff/1/include/core/SkRect.h#newco...
include/core/SkRect.h:758: void joinPossiblyEmptyArg(const SkRect& r) {
nit: I think joinPossiblyEmptyRect is more clear.

[bsalomon, 2015-05-01 15:45:12]

https://codereview.chromium.org/1118293002/diff/1/include/core/SkRect.h
File include/core/SkRect.h (right):

https://codereview.chromium.org/1118293002/diff/1/include/core/SkRect.h#newco...
include/core/SkRect.h:755: * Updates this rectangle to enclose itself and a
potentially empty rect.  We really treat the
I'm not sure the comment and name are right. The preconditions aren't just about
the arg, but also about "this". Maybe to be more consistent with some of the
other functions here this should be called "joinNoEmptyCheck"?

/** Joins the rectangle with another without checking if either are empty (may
produce unexpected results if either rect is inverted). */

??

[joshualitt, 2015-05-01 15:48:03]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-05-01 15:48:03]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1118293002/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2015-05-01 15:48:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1118293002/20001

[commit-bot: I haz the power, 2015-05-01 15:51:53]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3dc2ccae6c0f0cf6ac951585a197bfb8a58cfee5