Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1118273004: Migrate error messages, part 8. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Migrate error messages, part 8. R=mvstanton@chromium.org Committed: https://crrev.com/a5de69f4f88842eddd298e26e435acddf7660874 Cr-Commit-Position: refs/heads/master@{#28250}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -124 lines) Patch
M src/accessors.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/arraybuffer.js View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/factory.h View 2 chunks +6 lines, -2 lines 0 comments Download
M src/factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/messages.h View 6 chunks +23 lines, -1 line 0 comments Download
M src/messages.js View 1 chunk +0 lines, -24 lines 0 comments Download
M src/promise.js View 4 chunks +5 lines, -5 lines 0 comments Download
M src/proxy.js View 2 chunks +5 lines, -6 lines 0 comments Download
M src/runtime.js View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-array.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 7 chunks +38 lines, -44 lines 0 comments Download
M src/typedarray.js View 12 chunks +23 lines, -33 lines 0 comments Download
M test/mjsunit/messages.js View 5 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 7 months ago (2015-05-05 11:03:07 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118273004/1
5 years, 7 months ago (2015-05-05 13:21:54 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-05 14:02:11 UTC) #5
mvstanton
lgtm
5 years, 7 months ago (2015-05-06 07:45:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118273004/1
5 years, 7 months ago (2015-05-06 07:50:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 07:52:00 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 07:52:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5de69f4f88842eddd298e26e435acddf7660874
Cr-Commit-Position: refs/heads/master@{#28250}

Powered by Google App Engine
This is Rietveld 408576698