Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1118183003: content: Rename webkit_test_helpers.{cc,h} to blink_test_helpers.{cc,h} (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Rename webkit_test_helpers.{cc,h} to blink_test_helpers.{cc,h} Now that webkit/ is gone, we are preparing ourselves for the merge of third_party/WebKit into //blink. BUG=None BUG=content_shell && content_unittests R=avi@chromium.org Committed: https://crrev.com/685c3980d31b5199924086b8c93a1ce751d24733 Cr-Commit-Position: refs/heads/master@{#328202}

Patch Set 1 #

Patch Set 2 : content/shell/renderer/layout_test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -188 lines) Patch
M content/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_shell.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_main.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_content_browser_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/webkit_test_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D content/shell/common/webkit_test_helpers.h View 1 chunk +0 lines, -37 lines 0 comments Download
D content/shell/common/webkit_test_helpers.cc View 1 chunk +0 lines, -136 lines 0 comments Download
A + content/shell/renderer/layout_test/blink_test_helpers.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/shell/renderer/layout_test/blink_test_helpers.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/layout_test/layout_test_content_renderer_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
tfarina
5 years, 7 months ago (2015-05-04 17:41:47 UTC) #1
jochen (gone - plz use gerrit)
if you touch those files anyways, can you move them to the respective layout_tests/ subdirs ...
5 years, 7 months ago (2015-05-04 17:46:52 UTC) #3
tfarina
On 2015/05/04 17:46:52, jochen wrote: > if you touch those files anyways, can you move ...
5 years, 7 months ago (2015-05-04 17:50:45 UTC) #4
jochen (gone - plz use gerrit)
e.g. blink_test_helpers.cc should go into content/shell/renderer/layout_test/
5 years, 7 months ago (2015-05-04 17:52:30 UTC) #5
tfarina
Done. PTAL
5 years, 7 months ago (2015-05-04 18:00:21 UTC) #6
Avi (use Gerrit)
lgtm Whooo!
5 years, 7 months ago (2015-05-04 19:11:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118183003/20001
5 years, 7 months ago (2015-05-04 22:06:02 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-04 22:11:29 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 22:12:23 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/685c3980d31b5199924086b8c93a1ce751d24733
Cr-Commit-Position: refs/heads/master@{#328202}

Powered by Google App Engine
This is Rietveld 408576698