Gets InputMethodFocus tests added in r327286 working on Mac

Gets InputMethodFocus tests added in r327286 working on Mac

This is achieved by using the cross-platform APIs on views::Widget.
These APIs are at a different abstraction layer, so generally give
coverage that is a closer match to the situation in Release code.

In doing so, fix a possible use-after-free in
TouchSelectionControllerImpl that results when
Widget::OnNativeWidgetDestroying attempts to call
TouchSelectionControllerImpl::OnWidgetDestroying() on a deleted
observer. Coverage in
WidgetTestInteractive.TouchSelectionQuickMenuIsNotActivated

BUG=474828
Committed: https://crrev.com/5db26dbaa8002855e73abda366edc07d034e42bb
Cr-Commit-Position: refs/heads/master@{#328297}

[tapted, 2015-05-05 00:17:17]

Patchset #5 (id:70001) has been deleted

[tapted, 2015-05-05 00:22:41]

tapted@chromium.org changed reviewers:
+ sadrul@chromium.org, shuchen@chromium.org

[tapted, 2015-05-05 00:31:42]

Hi sadrul and shuchen, please take a look.

https://codereview.chromium.org/1118173003/diff/90001/ui/views/widget/widget_...
File ui/views/widget/widget_interactive_uitest.cc (right):

https://codereview.chromium.org/1118173003/diff/90001/ui/views/widget/widget_...
ui/views/widget/widget_interactive_uitest.cc:247:
widget->widget_delegate()->set_can_activate(true);
Unfortunately, this approach doesn't work on Windows -- I don't think we can
prevent the OS from setting a foreground window the way we can on Mac, so
::GetForegroundWindow() will just update back to the window we're trying to
deactivate unless the window sticks around (which is done for Windows in the
WidgetInputMethodInteractiveTest harness below).

[Shu Chen, 2015-05-05 02:37:06]

lgtm

Thanks for cleaning up the tests!

https://codereview.chromium.org/1118173003/diff/90001/ui/views/widget/widget_...
File ui/views/widget/widget_interactive_uitest.cc (right):

https://codereview.chromium.org/1118173003/diff/90001/ui/views/widget/widget_...
ui/views/widget/widget_interactive_uitest.cc:1558: // Window::Blur doesn't work
for CrOS, because it uses NWA instead of DNWA and
Please update the comment, actually Window::Blur will not be used in the
following code.

[sadrul, 2015-05-05 05:31:37]

rs lgtm

[tapted, 2015-05-05 06:38:30]

Thanks all!

https://codereview.chromium.org/1118173003/diff/90001/ui/views/widget/widget_...
File ui/views/widget/widget_interactive_uitest.cc (right):

https://codereview.chromium.org/1118173003/diff/90001/ui/views/widget/widget_...
ui/views/widget/widget_interactive_uitest.cc:1558: // Window::Blur doesn't work
for CrOS, because it uses NWA instead of DNWA and
On 2015/05/05 02:37:06, Shu Chen wrote:
> Please update the comment, actually Window::Blur will not be used in the
> following code.

Done.

[tapted, 2015-05-05 06:38:37]

The CQ bit was checked by tapted@chromium.org

[tapted, 2015-05-05 06:38:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
shuchen@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/1118173003/#ps110001
(title: "Update blur comment")

[commit-bot: I haz the power, 2015-05-05 06:38:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1118173003/110001

[commit-bot: I haz the power, 2015-05-05 08:03:06]

Committed patchset #6 (id:110001)

[commit-bot: I haz the power, 2015-05-05 08:04:07]

Patchset 6 (id:??) landed as
https://crrev.com/5db26dbaa8002855e73abda366edc07d034e42bb
Cr-Commit-Position: refs/heads/master@{#328297}