Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1118143003: Merge to XFA: Fix V8 array buffer allocator. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Tabify. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -12 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/javascript/JS_Runtime.h View 3 chunks +14 lines, -6 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 1 chunk +23 lines, -4 lines 0 comments Download
M xfa/src/fxjse/src/runtime.cpp View 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review. Not just a simple merge, but rather duplicate some code on the ...
5 years, 7 months ago (2015-04-30 22:15:30 UTC) #2
Lei Zhang
lgtm
5 years, 7 months ago (2015-04-30 22:18:18 UTC) #3
Tom Sepez
5 years, 7 months ago (2015-04-30 22:19:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d2cc1b90fe1ffd3162bb685a3f120f867220b5e9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698