content/common/presentation/presentation_service.mojom - Issue 1118103002: Implements ListenForSessionMessages in PresentationServiceImpl; uses Swap to avoid copying large da…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/presentation/presentation_service.mojom

Issue 1118103002: Implements ListenForSessionMessages in PresentationServiceImpl; uses Swap to avoid copying large da… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addresses Mark's comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/presentation/presentation_service_impl.cc ('K') | « content/browser/presentation/presentation_service_impl_unittest.cc ('k') | content/content_browser.gypi » ('j') | content/public/browser/presentation_session_message.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/presentation/presentation_service.mojom

diff --git a/content/common/presentation/presentation_service.mojom b/content/common/presentation/presentation_service.mojom

index 1ec3d7cddfbfeaffac102cad6403d513daeec294..7a8685b9009322cabe130c2ee3a141ea52a106ad 100644

--- a/content/common/presentation/presentation_service.mojom

+++ b/content/common/presentation/presentation_service.mojom

@@ -99,5 +99,5 @@ interface PresentationService {

// Called when the frame is ready to process the next batch of messages.

ListenForSessionMessages()

- => (array<SessionMessage> messages);

+ => (array<SessionMessage>? messages);

imcheng (use chromium acct) 2015/05/04 19:53:55 Document what it means to invoke the callback with

haibinlu 2015/05/04 21:33:50 Done.

};