Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: dart/tools/testing/dart/test_progress.dart

Issue 11181004: Group co19 results by runtime. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Handle "checked" runtimes Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tools/testing/dart/test_progress.dart
diff --git a/dart/tools/testing/dart/test_progress.dart b/dart/tools/testing/dart/test_progress.dart
index 81bfab10d0e6309bb6564bfc1bc15580a9c00282..bac5a71017e2f431e87b8d37c327b6794773d076 100644
--- a/dart/tools/testing/dart/test_progress.dart
+++ b/dart/tools/testing/dart/test_progress.dart
@@ -406,13 +406,32 @@ class DiffProgressIndicator extends ColorProgressIndicator {
configs.add(test.configurationString);
}
+ String _extractRuntime(String configuration) {
+ // Extract runtime from a configuration, for example,
+ // 'none-vm-checked release_ia32'.
+ List<String> runtime = config.split(' ')[0].split('-');
+ return '${runtime[0]}-${runtime[1]}';
+ }
+
void _printFailureSummary() {
Map<String, List<String>> groupedStatuses = new Map<String, List<String>>();
statusToConfigs.forEach((String status, List<String> configs) {
- configs.sort((a, b) => a.compareTo(b));
- List<String> statuses =
- groupedStatuses.putIfAbsent('$configs', () => <String>[]);
- statuses.add(status);
+ Map<String, List<String>> runtimeToConfiguration =
+ new Map<String, List<String>>();
+ for (String config in configs) {
+ String runtime = _extractRuntime(config);
+ List<String> runtimeConfigs =
+ runtimeToConfiguration.putIfAbsent(runtime, () => <String>[]);
+ runtimeConfigs.add(config);
+ }
+ runtimeToConfiguration.forEach((String runtime,
+ List<String> runtimeConfigs) {
+ runtimeConfigs.sort((a, b) => a.compareTo(b));
+ List<String> statuses =
+ groupedStatuses.putIfAbsent('$runtime: $runtimeConfigs',
+ () => <String>[]);
+ statuses.add(status);
+ });
});
groupedStatuses.forEach((String config, List<String> statuses) {
print('');
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698